Re: RFR: 8316493: Make immutable maps @ValueBased [v10]

2023-10-19 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased [v9]

2023-10-19 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased [v8]

2023-10-19 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased [v7]

2023-10-19 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased [v6]

2023-10-18 Thread Stuart Marks
On Wed, 18 Oct 2023 15:24:14 GMT, Per Minborg wrote: >> This PR outlines a solution for making immutable maps `@ValueBased` by >> removing cacheing of certain values in `AbstractMap`. >> >> By removing these caching fields in `AbstractMap`, we can make the immutable >> maps `@ValueBased` and a

Re: RFR: 8316493: Make immutable maps @ValueBased [v6]

2023-10-18 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased [v3]

2023-10-18 Thread Per Minborg
On Fri, 22 Sep 2023 15:31:13 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/util/AbstractMap.java line 524: >> >>> 522: protected Object clone() throws CloneNotSupportedException { >>> 523: AbstractMap result = (AbstractMap)super.clone(); >>> 524: return result; >

Re: RFR: 8316493: Make immutable maps @ValueBased [v5]

2023-10-18 Thread Per Minborg
On Tue, 19 Sep 2023 23:48:07 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/util/AbstractMap.java line 375: >> >>> 373: */ >>> 374: public Collection values() { >>> 375: return new AbstractCollection<>() { >> >> Note that this causes `m.values().equals(m.values())`

Re: RFR: 8316493: Make immutable maps @ValueBased [v5]

2023-10-18 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased [v4]

2023-10-18 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased [v3]

2023-09-22 Thread Chen Liang
On Fri, 22 Sep 2023 14:44:11 GMT, Glavo wrote: >> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since t

Re: RFR: 8316493: Make immutable maps @ValueBased [v3]

2023-09-22 Thread Glavo
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote: >> This PR outlines a solution for making immutable maps `@ValueBased` by >> removing cacheing of certain values in `AbstractMap`. >> >> By removing these caching fields in `AbstractMap`, we can make the immutable >> maps `@ValueBased` and a

Re: RFR: 8316493: Make immutable maps @ValueBased [v3]

2023-09-22 Thread Chen Liang
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote: >> This PR outlines a solution for making immutable maps `@ValueBased` by >> removing cacheing of certain values in `AbstractMap`. >> >> By removing these caching fields in `AbstractMap`, we can make the immutable >> maps `@ValueBased` and a

Re: RFR: 8316493: Make immutable maps @ValueBased [v3]

2023-09-22 Thread Per Minborg
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote: >> This PR outlines a solution for making immutable maps `@ValueBased` by >> removing cacheing of certain values in `AbstractMap`. >> >> By removing these caching fields in `AbstractMap`, we can make the immutable >> maps `@ValueBased` and a

Re: RFR: 8316493: Make immutable maps @ValueBased [v3]

2023-09-21 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased [v2]

2023-09-20 Thread Chen Liang
On Wed, 20 Sep 2023 06:04:26 GMT, Per Minborg wrote: >> This PR outlines a solution for making immutable maps `@ValueBased` by >> removing cacheing of certain values in `AbstractMap`. >> >> By removing these caching fields in `AbstractMap`, we can make the immutable >> maps `@ValueBased` and a

Re: RFR: 8316493: Make immutable maps @ValueBased [v2]

2023-09-19 Thread Per Minborg
> This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the same time, performance is likely improved > because t

Re: RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread Chen Liang
On Tue, 19 Sep 2023 18:38:06 GMT, ExE Boss wrote: >> This PR outlines a solution for making immutable maps `@ValueBased` by >> removing cacheing of certain values in `AbstractMap`. >> >> By removing these caching fields in `AbstractMap`, we can make the immutable >> maps `@ValueBased` and at t

Re: RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread Chen Liang
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote: > This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the

Re: RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread ExE Boss
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote: > This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the

Re: RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread Chen Liang
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote: > This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the

Re: RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread Per Minborg
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote: > This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the

Re: RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread Claes Redestad
On Thu, 7 Sep 2023 11:13:44 GMT, Per Minborg wrote: > This PR outlines a solution for making immutable maps `@ValueBased` by > removing cacheing of certain values in `AbstractMap`. > > By removing these caching fields in `AbstractMap`, we can make the immutable > maps `@ValueBased` and at the

RFR: 8316493: Make immutable maps @ValueBased

2023-09-19 Thread Per Minborg
This PR outlines a solution for making immutable maps `@ValueBased` by removing cacheing of certain values in `AbstractMap`. By removing these caching fields in `AbstractMap`, we can make the immutable maps `@ValueBased` and at the same time, performance is likely improved because the JVM is pr