Re: RFR: 8316426: Optimization for HexFormat.formatHex [v6]

2023-09-19 Thread Roger Riggs
On Tue, 19 Sep 2023 10:41:51 GMT, 温绍锦 wrote: >> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table >> were discussed. >> >> But if the input is byte[], using lookup table can improve performance. >> >> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v6]

2023-09-19 Thread Roger Riggs
On Tue, 19 Sep 2023 01:35:49 GMT, 温绍锦 wrote: >> The original (and current) is coded to avoid a condition inside the loop. > > I also think that the way of writing for_0 combined with if > 0 is easier to > understand, The operation overhead of if > 0 is very small, and it will not > affect perfo

Re: RFR: 8316426: Optimization for HexFormat.formatHex [v6]

2023-09-19 Thread 温绍锦
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table > were discussed. > > But if the input is byte[], using lookup table can improve performance. > > For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]), > If the length of byte[] is larger, the pe