Re: RFR: 8316050: Use hexadecimal encoding in MemorySegment::toString [v2]

2023-09-13 Thread Roger Riggs
On Wed, 13 Sep 2023 12:51:19 GMT, Per Minborg wrote: >> This PR proposes to use hexadecimal representation for a memory segment >> address rather than a decimal one. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Change fr

Re: RFR: 8316050: Use hexadecimal encoding in MemorySegment::toString [v2]

2023-09-13 Thread Per Minborg
> This PR proposes to use hexadecimal representation for a memory segment > address rather than a decimal one. Per Minborg has updated the pull request incrementally with one additional commit since the last revision: Change from limit to byteSize in MS::toString - Changes: -

Re: RFR: 8316050: Use hexadecimal encoding in MemorySegment::toString

2023-09-11 Thread Maurizio Cimadamore
On Mon, 11 Sep 2023 21:17:27 GMT, Per Minborg wrote: > This PR proposes to use hexadecimal representation for a memory segment > address rather than a decimal one. Marked as reviewed by mcimadamore (Reviewer). src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java lin

Re: RFR: 8316050: Use hexadecimal encoding in MemorySegment::toString

2023-09-11 Thread Roger Riggs
On Mon, 11 Sep 2023 21:17:27 GMT, Per Minborg wrote: > This PR proposes to use hexadecimal representation for a memory segment > address rather than a decimal one. Seems more natural. - Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15670#pul

RFR: 8316050: Use hexadecimal encoding in MemorySegment::toString

2023-09-11 Thread Per Minborg
This PR proposes to use hexadecimal representation for a memory segment address rather than a decimal one. - Commit messages: - Use hexadecimal encoding in MemorySegment::toString Changes: https://git.openjdk.org/jdk/pull/15670/files Webrev: https://webrevs.openjdk.org/?repo=jdk&p