On Wed, 30 Aug 2023 20:34:01 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
On Mon, 4 Sep 2023 08:01:16 GMT, Julian Waters wrote:
> Is this all clear for sponsorship?
Yes, I have checked with @dholmes-ora
-
PR Comment: https://git.openjdk.org/jdk/pull/15343#issuecomment-1704827486
On Wed, 30 Aug 2023 20:34:01 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains ten additional
commits sinc
On Fri, 25 Aug 2023 07:04:50 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
On Fri, 25 Aug 2023 07:04:50 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
On Fri, 25 Aug 2023 07:04:50 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains eight additional
commits si
On Mon, 21 Aug 2023 21:36:13 GMT, David Holmes wrote:
>>> Nit: no need to pre-declare this, just use `int error = getJavaPath(...)`
>>
>> This one was intentional to keep the style consistent =)
>
> The others are more widely used and there is a desire to document their
> meaning. That isn't ne
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request incrementally with one additional
commit since the last revision:
declare error in-place
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15343/files
- new: https://git.
On Mon, 21 Aug 2023 20:30:54 GMT, Vladimir Petko wrote:
>> src/java.base/unix/native/launcher/jexec.c line 162:
>>
>>> 160: int argi = 0; /* index into old array */
>>> 161: size_talen = 0; /* length of new array */
>>> 162: int e
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request incrementally with one additional
commit since the last revision:
remove unused imports
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15343/files
- new: https://git.o
On Mon, 21 Aug 2023 07:59:35 GMT, David Holmes wrote:
> Nit: no need to pre-declare this, just use `int error = getJavaPath(...)`
This one was intentional to keep the style consistent =)
-
PR Review Comment: https://git.openjdk.org/jdk/pull/15343#discussion_r1300614894
On Mon, 21 Aug 2023 07:14:44 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment: use /proc/self/exe as the backup option
On Mon, 21 Aug 2023 07:14:44 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment: use /proc/self/exe as the backup option
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request incrementally with one additional
commit since the last revision:
Review comment: use /proc/self/exe as the backup option
-
Changes:
- all: https://git.openjdk.org/jdk/pull/
On Mon, 21 Aug 2023 06:33:50 GMT, David Holmes wrote:
> To minimise the impact on existing users can this be implemented as a
> fallback if the initial attempt to locate `java` fails?
Updated and re-run the affected test:
==
Test summary
On Mon, 21 Aug 2023 06:18:15 GMT, Vladimir Petko wrote:
> realpath call in getJavaPath() function translates the symbolic link into the
> binary path.
Okay so a specific API makes this work as intended.
What I can't determine is whether this may have an adverse effect on anyone
using an "unus
On Mon, 21 Aug 2023 04:38:56 GMT, David Holmes wrote:
> I get the sense from the comment in jexec.c that it is only intended to be
> launched via a full path, so having it in the $PATH seems like a usage error
> to me.
Unfortunately this executable is linked in /usr/bin and is assumed to work
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains four additional
commits sin
On Fri, 18 Aug 2023 10:06:19 GMT, Vladimir Petko wrote:
> 8314491: Linux: jexec launched via PATH fails to find java
I get the sense from the comment in jexec.c that it is only intended to be
launched via a full path, so having it in the $PATH seems like a usage error to
me.
That said this ch
On Fri, 18 Aug 2023 10:06:19 GMT, Vladimir Petko wrote:
> 8314491: Linux: jexec launched via PATH fails to find java
When jexec is found in the PATH, e.g. we run ``$jexec myjar.jar``, the
`argv[0]` contains `jexec` and Java can not be found.
Running updated test without fix in jexec.c:
$make
8314491: Linux: jexec launched via PATH fails to find java
-
Commit messages:
- Use /proc/self/exec to identify path to the executable.
- Create failing test for jexec in PATH issue
Changes: https://git.openjdk.org/jdk/pull/15343/files
Webrev: https://webrevs.openjdk.org/?repo=jdk
23 matches
Mail list logo
