Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

2023-08-15 Thread Aleksey Shipilev
On Fri, 11 Aug 2023 15:32:58 GMT, Aleksey Shipilev wrote: >> When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), >> I realized there are no targeted tests for `FileDescriptor.sync` that can be >> used to qualify the changes in that area. >> >> Additionally, we use `FD

Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

2023-08-15 Thread Brian Burkhalter
On Fri, 11 Aug 2023 15:32:58 GMT, Aleksey Shipilev wrote: >> When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), >> I realized there are no targeted tests for `FileDescriptor.sync` that can be >> used to qualify the changes in that area. >> >> Additionally, we use `FD

Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

2023-08-15 Thread Aleksey Shipilev
On Fri, 11 Aug 2023 15:32:58 GMT, Aleksey Shipilev wrote: >> When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), >> I realized there are no targeted tests for `FileDescriptor.sync` that can be >> used to qualify the changes in that area. >> >> Additionally, we use `FD

Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

2023-08-14 Thread Aleksey Shipilev
On Sun, 13 Aug 2023 07:15:45 GMT, Alan Bateman wrote: > AutoDelete is probably a bit overkill but okay. Thanks! Any more takers? - PR Comment: https://git.openjdk.org/jdk/pull/15231#issuecomment-1677361679

Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

2023-08-13 Thread Alan Bateman
On Fri, 11 Aug 2023 15:32:58 GMT, Aleksey Shipilev wrote: >> When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), >> I realized there are no targeted tests for `FileDescriptor.sync` that can be >> used to qualify the changes in that area. >> >> Additionally, we use `FD

Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

2023-08-11 Thread Aleksey Shipilev
On Fri, 11 Aug 2023 14:32:29 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments > > test/jdk/java/io/FileDescriptor/Sync.java line 36: > >> 34: * @requires vm.continuations >> 3

Re: RFR: 8314120: Add tests for FileDescriptor.sync [v2]

2023-08-11 Thread Aleksey Shipilev
> When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), > I realized there are no targeted tests for `FileDescriptor.sync` that can be > used to qualify the changes in that area. > > Additionally, we use `FD.sync` for durability in Java databases, and we want > to make s

Re: RFR: 8314120: Add tests for FileDescriptor.sync

2023-08-11 Thread Alan Bateman
On Thu, 10 Aug 2023 15:45:12 GMT, Aleksey Shipilev wrote: > When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), > I realized there are no targeted tests for `FileDescriptor.sync` that can be > used to qualify the changes in that area. > > Additionally, we use `FD.sync

RFR: 8314120: Add tests for FileDescriptor.sync

2023-08-10 Thread Aleksey Shipilev
When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), I realized there are no targeted tests for FileDescriptor.sync that can be used to qualify the changes in that area. Additionally, we use FD.sync for durability in Java databases, and we want to make sure at least som