Re: RFR: 8313452: Improve Classfile API attributes handling safety [v4]

2023-09-14 Thread Adam Sotona
> This PR improved Classfile API attributes handling safety by introduction of > attribute stability indicator > and by extension of UnknownAttributesOption to more general > AttributesProcessingOption. Adam Sotona has updated the pull request incrementally with one additional commit since the

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v3]

2023-09-14 Thread Adam Sotona
On Thu, 14 Sep 2023 16:30:21 GMT, Brian Goetz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> magic moved to Util::isAttributeAllowed and fixed possible NPE > > src/java.base/share/classes/jdk/internal/classfile/Att

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v3]

2023-09-14 Thread Brian Goetz
On Wed, 6 Sep 2023 15:03:24 GMT, Adam Sotona wrote: >> This PR improved Classfile API attributes handling safety by introduction of >> attribute stability indicator >> and by extension of UnknownAttributesOption to more general >> AttributesProcessingOption. > > Adam Sotona has updated the pull

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v3]

2023-09-06 Thread Adam Sotona
> This PR improved Classfile API attributes handling safety by introduction of > attribute stability indicator > and by extension of UnknownAttributesOption to more general > AttributesProcessingOption. Adam Sotona has updated the pull request incrementally with one additional commit since the

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v3]

2023-09-06 Thread Adam Sotona
On Wed, 6 Sep 2023 13:54:28 GMT, ExE Boss wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> magic moved to Util::isAttributeAllowed and fixed possible NPE > > src/java.base/share/classes/jdk/internal/classfile/impl/Ab

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v2]

2023-09-06 Thread ExE Boss
On Wed, 6 Sep 2023 12:28:05 GMT, Adam Sotona wrote: >> This PR improved Classfile API attributes handling safety by introduction of >> attribute stability indicator >> and by extension of UnknownAttributesOption to more general >> AttributesProcessingOption. > > Adam Sotona has updated the pull

Re: RFR: 8313452: Improve Classfile API attributes handling safety [v2]

2023-09-06 Thread Adam Sotona
> This PR improved Classfile API attributes handling safety by introduction of > attribute stability indicator > and by extension of UnknownAttributesOption to more general > AttributesProcessingOption. Adam Sotona has updated the pull request with a new target base due to a merge or a rebase.

RFR: 8313452: Improve Classfile API attributes handling safety

2023-09-05 Thread Adam Sotona
This PR improved Classfile API attributes handling safety by introduction of attribute stability indicator and by extension of UnknownAttributesOption to more general AttributesProcessingOption. - Commit messages: - fixed remaining listFromTrustedArrayNullsAllowed calls to listFro