Re: RFR: 8312491: Update Classfile API snippets and examples [v11]

2023-09-05 Thread Jan Lahoda
On Fri, 1 Sep 2023 12:13:05 GMT, Adam Sotona wrote: >> This pull request updates Classfile API snippets and examples and adds >> missing javadoc. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8312491: Update Classfile API snippets and examples [v11]

2023-09-01 Thread Adam Sotona
> This pull request updates Classfile API snippets and examples and adds > missing javadoc. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: added notes to attributes - Changes: -

Re: RFR: 8312491: Update Classfile API snippets and examples [v10]

2023-08-31 Thread Adam Sotona
On Wed, 30 Aug 2023 12:39:45 GMT, Adam Sotona wrote: >> This pull request updates Classfile API snippets and examples and adds >> missing javadoc. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8312491: Update Classfile API snippets and examples [v10]

2023-08-30 Thread Adam Sotona
> This pull request updates Classfile API snippets and examples and adds > missing javadoc. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixing javadoc - Changes: - all: https

Re: RFR: 8312491: Update Classfile API snippets and examples [v9]

2023-08-30 Thread Adam Sotona
> This pull request updates Classfile API snippets and examples and adds > missing javadoc. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixing javadoc - Changes: - all: https

Re: RFR: 8312491: Update Classfile API snippets and examples [v8]

2023-08-30 Thread Adam Sotona
> This pull request updates Classfile API snippets and examples and adds > missing javadoc. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - fixing javadoc - fixing javadoc - Cha

Re: RFR: 8312491: Update Classfile API snippets and examples [v7]

2023-08-08 Thread Adam Sotona
> This pull request updates Classfile API snippets and examples and adds > missing javadoc. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: removed extra lines - Changes: - all:

Re: RFR: 8312491: Update Classfile API snippets and examples [v6]

2023-07-28 Thread Adam Sotona
On Thu, 27 Jul 2023 15:16:33 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line >> 1239: >> >>> 1237: return ldc(BytecodeHelpers.constantEntry(constantPool(), >>> value)); >>> 1238: } >>> 1239: >> >> Method needs specification > >

Re: RFR: 8312491: Update Classfile API snippets and examples [v6]

2023-07-28 Thread Adam Sotona
> This pull request updates Classfile API snippets and examples and adds > missing javadoc. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - fixing javadoc - fixing javadoc - Cha

Re: RFR: 8312491: Update Classfile API snippets and examples [v5]

2023-07-28 Thread Adam Sotona
> 8312491: Update Classfile API snippets and examples Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - fixing javadoc - fixing javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/14968/files - new: https://gi

Re: RFR: 8312491: Update Classfile API snippets and examples [v4]

2023-07-28 Thread Adam Sotona
> 8312491: Update Classfile API snippets and examples Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixing javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/14968/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8312491: Update Classfile API snippets and examples [v3]

2023-07-27 Thread Adam Sotona
> 8312491: Update Classfile API snippets and examples Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixing javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/14968/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8312491: Update Classfile API snippets and examples [v2]

2023-07-27 Thread Adam Sotona
> 8312491: Update Classfile API snippets and examples Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixing javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/14968/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8312491: Update Classfile API snippets and examples

2023-07-27 Thread Adam Sotona
On Thu, 27 Jul 2023 14:59:49 GMT, Brian Goetz wrote: >> 8312491: Update Classfile API snippets and examples > > src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line 1239: > >> 1237: return ldc(BytecodeHelpers.constantEntry(constantPool(), >> value)); >> 1238: } >

Re: RFR: 8312491: Update Classfile API snippets and examples

2023-07-27 Thread Brian Goetz
On Fri, 21 Jul 2023 09:37:10 GMT, Adam Sotona wrote: > 8312491: Update Classfile API snippets and examples src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line 1239: > 1237: return ldc(BytecodeHelpers.constantEntry(constantPool(), > value)); > 1238: } > 1239:

RFR: 8312491: Update Classfile API snippets and examples

2023-07-27 Thread Adam Sotona
8312491: Update Classfile API snippets and examples - Commit messages: - 8312491: Update Classfile API snippets and examples Changes: https://git.openjdk.org/jdk/pull/14968/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14968&range=00 Issue: https://bugs.openjdk.org/brows