Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-08-15 Thread Aleksey Shipilev
On Thu, 10 Aug 2023 11:54:05 GMT, Cristian Vat wrote: >> Shouldn't the similar change be in `CIBackRef.match` too? The fact current >> tests do not catch it makes me uneasy: the test coverage seems to be rather >> low there. >> >> We need a regex expert to look at it. @rgiulietti @igraves mig

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-08-10 Thread Aleksey Shipilev
On Fri, 28 Jul 2023 08:40:30 GMT, Aleksey Shipilev wrote: >> Cristian Vat has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reduce allocations also for Matcher.usePattern > > Shouldn't the similar change be in `CIBackRef.match` too? The fa

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-08-10 Thread Cristian Vat
On Fri, 28 Jul 2023 08:40:30 GMT, Aleksey Shipilev wrote: >> Cristian Vat has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reduce allocations also for Matcher.usePattern > > Shouldn't the similar change be in `CIBackRef.match` too? The fa

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-28 Thread Cristian Vat
On Fri, 28 Jul 2023 08:25:55 GMT, Aleksey Shipilev wrote: >> Cristian Vat has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reduce allocations also for Matcher.usePattern > > src/java.base/share/classes/java/util/regex/Pattern.java line 51

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-28 Thread Aleksey Shipilev
On Sat, 22 Jul 2023 12:13:10 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-28 Thread Cristian Vat
On Sat, 22 Jul 2023 12:13:10 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-22 Thread Cristian Vat
On Sat, 22 Jul 2023 12:13:10 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

2023-07-22 Thread Cristian Vat
> Reduces excessive allocation of Matcher.groups array when the original > Pattern has no groups or less than 9 groups. > > Original clamping to 10 possibly due to documented behavior from javadoc: > "In this class, \1 through \9 are always interpreted as back references, " > > Only with Matche