Re: [jdk21] RFR: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads

2023-07-13 Thread Jaikiran Pai
On Thu, 13 Jul 2023 15:58:24 GMT, Alan Bateman wrote: > Clean backport of https://git.openjdk.org/jdk/pull/14833 P3 bug fix, approved for backport. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk21/pull/123#pullrequestreview-1529421300

[jdk21] RFR: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads

2023-07-13 Thread Alan Bateman
Clean backport of https://git.openjdk.org/jdk/pull/14833 - Commit messages: - Backport 92a04e201e68aa4d682053cef4b36180ec5620f5 Changes: https://git.openjdk.org/jdk21/pull/123/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=123&range=00 Issue: https://bugs.openjdk.org/br

Re: RFR: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads

2023-07-12 Thread Alan Bateman
On Wed, 12 Jul 2023 11:47:45 GMT, Jaikiran Pai wrote: > As for the 15 "afterShutdown" forks() that follow, they would already notice > that the scope is shutdown and won't start the new threads. > Did I misunderstand this test? The test arranges for a subtask to do shutdown, it's not done by th

Re: RFR: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads

2023-07-12 Thread Jaikiran Pai
On Wed, 12 Jul 2023 11:56:18 GMT, Alan Bateman wrote: >> test/jdk/java/util/concurrent/StructuredTaskScope/StressShutdown.java line >> 83: >> >>> 81: // fork subtask to shutdown >>> 82: scope.fork(() -> { >>> 83: scope.shutdown(); >> >> Hello Alan, the p

Re: RFR: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads

2023-07-12 Thread Jaikiran Pai
On Tue, 11 Jul 2023 17:03:26 GMT, Alan Bateman wrote: > StructuredTaskScope.shutdown can sometimes not interrupt the thread for a > newly forked subtask, leading to join blocking until subtask completes. The > "hang" can be duplicated with a stress test that shuts down the scope while a > long

Re: RFR: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads

2023-07-12 Thread Jaikiran Pai
On Tue, 11 Jul 2023 17:03:26 GMT, Alan Bateman wrote: > StructuredTaskScope.shutdown can sometimes not interrupt the thread for a > newly forked subtask, leading to join blocking until subtask completes. The > "hang" can be duplicated with a stress test that shuts down the scope while a > long

RFR: 8311867: StructuredTaskScope.shutdown does not interrupt newly started threads

2023-07-12 Thread Alan Bateman
StructuredTaskScope.shutdown can sometimes not interrupt the thread for a newly forked subtask, leading to join blocking until subtask completes. The "hang" can be duplicated with a stress test that shuts down the scope while a long running subtask is being forked. The bug is in the underlying t