Re: [jdk21] RFR: 8309853: StructuredTaskScope.join description improvements

2023-06-22 Thread Joe Darcy
On Thu, 22 Jun 2023 10:45:02 GMT, Alan Bateman wrote: > 8309853: StructuredTaskScope.join description improvements Marked as reviewed by darcy (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/55#pullrequestreview-1493621677

[jdk21] RFR: 8309853: StructuredTaskScope.join description improvements

2023-06-22 Thread Alan Bateman
8309853: StructuredTaskScope.join description improvements - Commit messages: - Backport 3661cdee1b20ab2868025637871d22bb30add6bd Changes: https://git.openjdk.org/jdk21/pull/55/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=55&range=00 Issue: https://bugs.openjdk.org/br

Re: RFR: 8309853: StructuredTaskScope.join description improvements

2023-06-21 Thread Joe Darcy
On Mon, 12 Jun 2023 14:32:07 GMT, Alan Bateman wrote: > StructuredTaskScope's class description introduces the join method as waiting > for all subtasks to finish but the API docs for join/joinUntil are phrased in > terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil > inh

Re: RFR: 8309853: StructuredTaskScope.join description improvements

2023-06-17 Thread Ron Pressler
On Mon, 12 Jun 2023 14:32:07 GMT, Alan Bateman wrote: > StructuredTaskScope's class description introduces the join method as waiting > for all subtasks to finish but the API docs for join/joinUntil are phrased in > terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil > inh

RFR: 8309853: StructuredTaskScope.join description improvements

2023-06-13 Thread Alan Bateman
StructuredTaskScope's class description introduces the join method as waiting for all subtasks to finish but the API docs for join/joinUntil are phrased in terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil inherit this description but would be clearer if their description