On Thu, 15 Jun 2023 18:22:46 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request incrementally with one additional
On Thu, 15 Jun 2023 18:22:46 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request incrementally with one additional
On Thu, 15 Jun 2023 08:23:58 GMT, Aleksey Shipilev wrote:
>> Man Cao has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional commits
>>
On Thu, 15 Jun 2023 18:17:17 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request incrementally with one additional
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request incrementally with one additional commit
since the last revision:
Update comment
--
On Thu, 15 Jun 2023 00:16:15 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request with a new target base due to a m
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request with a new target base due to a merge or a
rebase. The incremental webrev excludes the unre
On Thu, 15 Jun 2023 00:05:32 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request incrementally with one additional
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request incrementally with one additional commit
since the last revision:
Removed volatile and c
On Tue, 13 Jun 2023 20:42:49 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request incrementally with one additional
On Tue, 13 Jun 2023 19:42:44 GMT, Aleksey Shipilev wrote:
>> Man Cao has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>> s
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request incrementally with one additional commit
since the last revision:
Switch to using volati
On Tue, 13 Jun 2023 19:24:08 GMT, Man Cao wrote:
>> Hi all,
>>
>> Could anyone review this small fix for a data race in
>> java.io.ClassCache$CacheRef? This fix makes the code safer by making the
>> code data-race-free.
>
> Man Cao has updated the pull request with a new target base due to a m
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Man Cao has updated the pull request with a new target base due to a merge or a
rebase. The incremental webrev excludes the unre
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Looks fine.
-
Marked as reviewed by rriggs (Reviewer).
PR Review
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
Agree with the analysis that this race looks benign, and the slight change in
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
I think the race is benign also but the change maintains the essential
semanti
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
If I read the existing code correctly, ClassCache::get can't return null. If
there are two
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
The presubmit failure on linux-x86 looks unrelated to this PR. It is
https://b
On Thu, 8 Jun 2023 22:06:56 GMT, Man Cao wrote:
> Hi all,
>
> Could anyone review this small fix for a data race in
> java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
> data-race-free.
The pre-submit failures for windows are due to
https://bugs.openjdk.org/browse
Hi all,
Could anyone review this small fix for a data race in
java.io.ClassCache$CacheRef? This fix makes the code safer by making the code
data-race-free.
-
Commit messages:
- 8309688: Data race on java.io.ClassCache.strongReferent
Changes: https://git.openjdk.org/jdk/pull/14386
21 matches
Mail list logo
