On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote:
>> This change prevents the contents of the internal string array from being
>> copied back when releasing it.
>
> Rudi Horn has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one com
On Wed, 31 May 2023 11:49:00 GMT, Rudi Horn wrote:
> I have not checked other uses, but they are probably not as critical yet
> given the special status and frequent use of strings. I can possibly revisit
> this issue in the future in a further issue / PR if I find time at some stage.
Okay, we
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote:
>> This change prevents the contents of the internal string array from being
>> copied back when releasing it.
>
> Rudi Horn has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one com
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote:
>> This change prevents the contents of the internal string array from being
>> copied back when releasing it.
>
> Rudi Horn has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one com
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote:
>> This change prevents the contents of the internal string array from being
>> copied back when releasing it.
>
> Rudi Horn has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one com
On Sat, 27 May 2023 14:21:28 GMT, Alan Bateman wrote:
> This looks okay. Have you checked the other usages of
> ReleasePrimitiveArrayCritical (e.g. libzip) see if they need the copy back
> when releasing?
I can immediately see code in `Java_java_util_zip_Inflater_inflateBytesBytes`
that needs
On Fri, 26 May 2023 19:54:07 GMT, Rudi Horn wrote:
>> This change prevents the contents of the internal string array from being
>> copied back when releasing it.
>
> Rudi Horn has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one com
> This change prevents the contents of the internal string array from being
> copied back when releasing it.
Rudi Horn has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains one commit:
Use JNI_ABORT to release string bytes
-
On Fri, 26 May 2023 17:36:12 GMT, Michael McMahon wrote:
> There was an unrelated change to these functions recently. You might want to
> rebase this PR with the latest version.
Done
-
PR Comment: https://git.openjdk.org/jdk/pull/14117#issuecomment-1564855730
On Wed, 24 May 2023 09:24:46 GMT, Rudi Horn wrote:
> This change prevents the contents of the internal string array from being
> copied back when releasing it.
There was an unrelated change to these functions recently. You might want to
rebase this PR with the latest version.
-
P
This change prevents the contents of the internal string array from being
copied back when releasing it.
-
Commit messages:
- Use JNI_ABORT to release string bytes
Changes: https://git.openjdk.org/jdk/pull/14117/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14117&range=00
11 matches
Mail list logo
