Re: RFR: 8307466: java.time.Instant calculation bug in until and between methods [v2]

2023-05-08 Thread Roger Riggs
On Mon, 8 May 2023 19:05:43 GMT, Raffaello Giulietti wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Slight perf improvement using int instead of long for local nanosDiff > > I think that the explanation of the old

Re: RFR: 8307466: java.time.Instant calculation bug in until and between methods [v2]

2023-05-08 Thread Raffaello Giulietti
On Sun, 7 May 2023 17:58:26 GMT, Roger Riggs wrote: >> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases >> did not correctly borrow or carry from the nanos to the seconds when >> computing using ChronoUnit.MILLIS or ChronoUnit.MICROS. >> The errant computation was int

Re: RFR: 8307466: java.time.Instant calculation bug in until and between methods [v2]

2023-05-08 Thread Roger Riggs
On Sun, 7 May 2023 17:58:26 GMT, Roger Riggs wrote: >> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases >> did not correctly borrow or carry from the nanos to the seconds when >> computing using ChronoUnit.MILLIS or ChronoUnit.MICROS. >> The errant computation was int

Re: RFR: 8307466: java.time.Instant calculation bug in until and between methods [v2]

2023-05-08 Thread Naoto Sato
On Sun, 7 May 2023 17:58:26 GMT, Roger Riggs wrote: >> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases >> did not correctly borrow or carry from the nanos to the seconds when >> computing using ChronoUnit.MILLIS or ChronoUnit.MICROS. >> The errant computation was int

Re: RFR: 8307466: java.time.Instant calculation bug in until and between methods [v2]

2023-05-07 Thread Roger Riggs
> The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases > did not correctly borrow or carry from the nanos to the seconds when > computing using ChronoUnit.MILLIS or ChronoUnit.MICROS. > The errant computation was introduced by > [JDK-8273369](https://bugs.openjdk.org/brows

Re: RFR: 8307466: java.time.Instant calculation bug in until and between methods

2023-05-06 Thread Raffaello Giulietti
On Fri, 5 May 2023 21:28:25 GMT, Roger Riggs wrote: > The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases > did not correctly borrow or carry from the nanos to the seconds when > computing using ChronoUnit.MILLIS or ChronoUnit.MICROS. > The errant computation was introdu

Re: RFR: 8307466: java.time.Instant calculation bug in until and between methods

2023-05-06 Thread Stephen Colebourne
On Fri, 5 May 2023 21:28:25 GMT, Roger Riggs wrote: > The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases > did not correctly borrow or carry from the nanos to the seconds when > computing using ChronoUnit.MILLIS or ChronoUnit.MICROS. > The errant computation was introdu

RFR: 8307466: java.time.Instant calculation bug in until and between methods

2023-05-05 Thread Roger Riggs
The implementation of java.time.Instant.until(I2, ChronoUnit) in some cases did not correctly borrow or carry from the nanos to the seconds when computing using ChronoUnit.MILLIS or ChronoUnit.MICROS. The errant computation was introduced by [JDK-8273369](https://bugs.openjdk.org/browse/JDK-8273