On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote:
> Spotted the typo for BootstrapMethods, and another review over the API
> exposed the typo on PermittedSubclasses.
Withdrawing this patch in favor of removing `validSince` completely in another
patch.
-
PR Comment: https://git.
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote:
> Spotted the typo for BootstrapMethods, and another review over the API
> exposed the typo on PermittedSubclasses.
Agree; we should remove this validsince. I change PermittedSubclasses for
Record uses its release major version than its previ
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote:
> Spotted the typo for BootstrapMethods, and another review over the API
> exposed the typo on PermittedSubclasses.
BootstrapMethods is a good catch, however I would rather recommend to remove
the `AttributeMapper::validSince` from the API co
On Wed, 19 Apr 2023 14:31:36 GMT, Chen Liang wrote:
> Spotted the typo for BootstrapMethods, and another review over the API
> exposed the typo on PermittedSubclasses.
@asotona Would you mind reviewing this?
-
PR Comment: https://git.openjdk.org/jdk/pull/13536#issuecomment-1529491
Spotted the typo for BootstrapMethods, and another review over the API exposed
the typo on PermittedSubclasses.
-
Commit messages:
- 8306455: Wrong majorVersion for multiple attributes in Classfile API
Changes: https://git.openjdk.org/jdk/pull/13536/files
Webrev: https://webrevs.o
