> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Tue, 9 May 2023 11:59:08 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>> com
On Tue, 9 May 2023 11:11:36 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file vers
On Tue, 9 May 2023 11:11:36 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file vers
On Tue, 9 May 2023 11:11:36 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file vers
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Thu, 4 May 2023 16:19:04 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file vers
On Fri, 5 May 2023 02:50:45 GMT, Chen Liang wrote:
> Since we want an option to toggle stackmap generation, will you add it to the
> Classfile options as a temporary measure, before we keep track of these
> options in a stateful object (with hierarchy resolver etc.) like brian
> envisioned?
I
On Thu, 4 May 2023 16:19:04 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file vers
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Thu, 4 May 2023 15:19:02 GMT, Chen Liang wrote:
> Also, has brian reviewed the DiscontinuedInstruction API changes?
https://mail.openjdk.org/pipermail/classfile-api-dev/2023-April/000292.html
-
PR Comment: https://git.openjdk.org/jdk/pull/13478#issuecomment-1535028314
On Tue, 2 May 2023 14:15:27 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file vers
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Thu, 20 Apr 2023 08:24:40 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/BufWriterImpl.java
>> line 86:
>>
>>> 84: }
>>> 85:
>>> 86: public void setMajorVersion(int majorVersion) {
>>
>> We should ensure the version is not changed once writing ha
On Thu, 20 Apr 2023 17:21:49 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file ver
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Wed, 19 Apr 2023 13:30:44 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> DiscontinuedInstruction implementation + test
>
> src/java.base/share/classes/jdk/internal/classfile/impl/DirectCodeBuilde
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Wed, 19 Apr 2023 17:08:53 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed ClassPrinterImpl
>
> src/java.base/share/classes/jdk/internal/classfile/impl/BufWriterImpl.java
> line 86:
>
>> 84
On Wed, 19 Apr 2023 13:44:47 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file ver
On Wed, 19 Apr 2023 13:44:47 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file ver
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Wed, 19 Apr 2023 13:06:20 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file ver
On Wed, 19 Apr 2023 13:06:20 GMT, Adam Sotona wrote:
>> Classfile API didn't handle transformations of class files version 50 and
>> below correctly.
>>
>> Proposed fix have two parts:
>> 1. Inflation of branch targets does not depend on StackMapTable attribute
>> presence for class file ver
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 50 and below. Alternative fallback
> implementation is
On Fri, 14 Apr 2023 14:02:46 GMT, Adam Sotona wrote:
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 5
On Fri, 14 Apr 2023 14:02:46 GMT, Adam Sotona wrote:
> Classfile API didn't handle transformations of class files version 50 and
> below correctly.
>
> Proposed fix have two parts:
> 1. Inflation of branch targets does not depend on StackMapTable attribute
> presence for class file version 5
Classfile API didn't handle transformations of class files version 50 and below
correctly.
Proposed fix have two parts:
1. Inflation of branch targets does not depend on StackMapTable attribute
presence for class file version 50 and below. Alternative fallback
implementation is provided.
2.
33 matches
Mail list logo
