On Tue, 11 Apr 2023 13:40:39 GMT, Weijun Wang wrote:
> Enhance the `Proc` utility to support compilation.
test/lib/jdk/test/lib/process/Proc.java line 331:
> 329:
> 330: if (compile) {
> 331: var comp = CompilerUtils.compile(
I don't find this use of `var` helpful - `var`
On Tue, 11 Apr 2023 13:40:39 GMT, Weijun Wang wrote:
> Enhance the `Proc` utility to support compilation.
test/lib/jdk/test/lib/process/Proc.java line 274:
> 272: }
> 273: // Compile as well
> 274: public Proc compile() throws IOException {
Why "throws IOException" ? I'm surprised
Enhance the `Proc` utility to support compilation.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/13425/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13425&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8305846
Stats: 139 lines in 4 files c
