Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-07 Thread Mandy Chung
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to report

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-07 Thread Mandy Chung
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to report

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-06 Thread Alan Bateman
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to report

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-05 Thread Jaikiran Pai
On Fri, 5 May 2023 14:10:42 GMT, Roger Riggs wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 71: >> >>> 69: */ >>> 70: public static Platform runtime() { >>> 71: return new Platform(OperatingSystem.current(), >>> Architecture.current()); >> >>

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-05 Thread Jaikiran Pai
On Fri, 5 May 2023 13:59:37 GMT, Roger Riggs wrote: >> Refactor the Platform class of jlink to use jdk.internal.util >> OperatingSystem and Architecture instead of os.name and os.arch. >> They are direct replacements for the Platform enums except for UNKNOWN; its >> use is refactored to report

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-05 Thread Roger Riggs
On Thu, 4 May 2023 12:36:32 GMT, Jaikiran Pai wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Source code cleanup suggested by reviewers > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 71

Re: RFR: 8304913: Use OperatingSystem, Architecture, and Version in jlink [v3]

2023-05-05 Thread Roger Riggs
> Refactor the Platform class of jlink to use jdk.internal.util OperatingSystem > and Architecture instead of os.name and os.arch. > They are direct replacements for the Platform enums except for UNKNOWN; its > use is refactored to report errors via exceptions. > > Neither os.name nor os.arch s