Re: RFR: 8304871: Use default visibility for static library builds [v2]

2023-03-30 Thread Severin Gehwolf
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote: >> Please review this change for symbol visibility of static library artefacts. >> This fixes an issue when >> OpenJDK is being used as a base for generating native images preventing the >> symbols from being >> exported and looked up fro

Re: RFR: 8304871: Use default visibility for static library builds [v2]

2023-03-29 Thread David Holmes
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote: >> Please review this change for symbol visibility of static library artefacts. >> This fixes an issue when >> OpenJDK is being used as a base for generating native images preventing the >> symbols from being >> exported and looked up fro

Re: RFR: 8304871: Use default visibility for static library builds [v2]

2023-03-28 Thread Severin Gehwolf
On Tue, 28 Mar 2023 04:40:24 GMT, David Holmes wrote: > I also added this to JBS: > > JDK-8239563 was also done to support Graal, and this change is now undoing > that. Do the Graal folk who want this understand it will restore the problem > that JDK-8239563 fixed? I have no insight as to why

Re: RFR: 8304871: Use default visibility for static library builds [v2]

2023-03-27 Thread David Holmes
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote: >> Please review this change for symbol visibility of static library artefacts. >> This fixes an issue when >> OpenJDK is being used as a base for generating native images preventing the >> symbols from being >> exported and looked up fro

Re: RFR: 8304871: Use default visibility for static library builds [v2]

2023-03-27 Thread Severin Gehwolf
On Mon, 27 Mar 2023 13:04:28 GMT, Erik Joelsson wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Explicitly set the JNI_EXPORT define for static libs > > Marked as reviewed by erikj (Reviewer). Thanks for the re

Re: RFR: 8304871: Use default visibility for static library builds [v2]

2023-03-27 Thread Erik Joelsson
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote: >> Please review this change for symbol visibility of static library artefacts. >> This fixes an issue when >> OpenJDK is being used as a base for generating native images preventing the >> symbols from being >> exported and looked up fro

Re: RFR: 8304871: Use default visibility for static library builds [v2]

2023-03-27 Thread Severin Gehwolf
> Please review this change for symbol visibility of static library artefacts. > This fixes an issue when > OpenJDK is being used as a base for generating native images preventing the > symbols from being > exported and looked up from the executable. Note that symbol visibity is now > controlled

Re: RFR: 8304871: Use default visibility for static library builds [v2]

2023-03-27 Thread Severin Gehwolf
On Mon, 27 Mar 2023 08:56:15 GMT, Severin Gehwolf wrote: >> make/autoconf/flags-cflags.m4 line 639: >> >>> 637: STATIC_LIBS_CFLAGS="-DSTATIC_BUILD=1" >>> 638: if test "x$TOOLCHAIN_TYPE" = xgcc || test "x$TOOLCHAIN_TYPE" = >>> xclang; then >>> 639: STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS

Re: RFR: 8304871: Use default visibility for static library builds

2023-03-27 Thread Severin Gehwolf
On Mon, 27 Mar 2023 05:23:26 GMT, David Holmes wrote: >> Please review this change for symbol visibility of static library artefacts. >> This fixes an issue when >> OpenJDK is being used as a base for generating native images preventing the >> symbols from being >> exported and looked up from t

Re: RFR: 8304871: Use default visibility for static library builds

2023-03-26 Thread David Holmes
On Fri, 24 Mar 2023 15:31:32 GMT, Severin Gehwolf wrote: > Please review this change for symbol visibility of static library artefacts. > This fixes an issue when > OpenJDK is being used as a base for generating native images preventing the > symbols from being > exported and looked up from the

RFR: 8304871: Use default visibility for static library builds

2023-03-24 Thread Severin Gehwolf
Please review this change for symbol visibility of static library artefacts. This fixes an issue when OpenJDK is being used as a base for generating native images preventing the symbols from being exported and looked up from the executable. Note that symbol visibity is now controlled by a linker