Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy [v3]

2023-04-19 Thread Chen Liang
On Wed, 22 Mar 2023 22:52:19 GMT, Chen Liang wrote: >> Without this patch, the Classfile API tries to encode PrimitiveClassDesc as >> CONSTANT_Class_info and error in `toInternalName`. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy [v3]

2023-03-22 Thread Chen Liang
> Without this patch, the Classfile API tries to encode PrimitiveClassDesc as > CONSTANT_Class_info and error in `toInternalName`. Chen Liang has updated the pull request incrementally with one additional commit since the last revision: PrimitiveClassConstantTest check the other 2 API endpoin

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy [v2]

2023-03-22 Thread Chen Liang
> Without this patch, the Classfile API tries to encode PrimitiveClassDesc as > CONSTANT_Class_info and error in `toInternalName`. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the m

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy

2023-03-21 Thread Chen Liang
On Mon, 13 Mar 2023 08:13:44 GMT, Chen Liang wrote: > Without this patch, the Classfile API tries to encode PrimitiveClassDesc as > CONSTANT_Class_info and error in `toInternalName`. Seems this bug exists in `ConstantPoolBuilder::constantValueEntry` as well. - PR Comment: https://

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy

2023-03-14 Thread liach
On Tue, 14 Mar 2023 17:32:00 GMT, ExE Boss wrote: > I meant that `instanceof DynamicConstantDesc` would go after concrete classes > (`Integer`, `Long`, `Float`, `Double`, and `String`), but before the  > `ConstantDesc` interfaces. Still not feasible to make ReferenceClassDescImpl to go through

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy

2023-03-14 Thread ExE Boss
On Mon, 13 Mar 2023 08:13:44 GMT, liach wrote: > Without this patch, the Classfile API tries to encode PrimitiveClassDesc as > CONSTANT_Class_info and error in `toInternalName`. I meant that `instanceof DynamicConstantDesc` would go after concrete classes (`Integer`, `Long`, `Float`, `Double`,

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy

2023-03-13 Thread liach
On Mon, 13 Mar 2023 23:46:58 GMT, ExE Boss wrote: > Arguably, the `instanceof DynamicConstantDesc` check should go first, as  > there can be only one superclass, but multiple implemented interfaces. I think this ordering is rather ranked by their relative frequency in bytecode. Having integer c

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy

2023-03-13 Thread ExE Boss
On Mon, 13 Mar 2023 08:13:44 GMT, liach wrote: > Without this patch, the Classfile API tries to encode PrimitiveClassDesc as > CONSTANT_Class_info and error in `toInternalName`. Arguably, the `instanceof DynamicConstantDesc` check should go first, as there  can be only one superclass, but multi

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy

2023-03-13 Thread Adam Sotona
On Mon, 13 Mar 2023 08:13:44 GMT, liach wrote: > Without this patch, the Classfile API tries to encode PrimitiveClassDesc as > CONSTANT_Class_info and error in `toInternalName`. Looks good, thanks for catching and fixing it. - Marked as reviewed by asotona (Committer). PR: https:

Re: RFR: 8304031: Classfile API cannot encode Primitive Class as Condy

2023-03-13 Thread liach
On Mon, 13 Mar 2023 08:13:44 GMT, liach wrote: > Without this patch, the Classfile API tries to encode PrimitiveClassDesc as > CONSTANT_Class_info and error in `toInternalName`. @asotona Would you mind review this? - PR: https://git.openjdk.org/jdk/pull/12996

RFR: 8304031: Classfile API cannot encode Primitive Class as Condy

2023-03-13 Thread liach
Without this patch, the Classfile API tries to encode PrimitiveClassDesc as CONSTANT_Class_info and error in `toInternalName`. - Commit messages: - 8304031: Classfile API cannot encode Primitive Class as Condy Changes: https://git.openjdk.org/jdk/pull/12996/files Webrev: https://w