On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Fri, 3 Nov 2023 20:01:44 GMT, Eirik Bjorsnos wrote:
> > I can kick of a test run internally next week or perhaps Sunday
>
> Thanks for your reviews, Lance and Iris!
>
> FWIW, the test ran fine on Github Actions, including on `linux-x86` (which is
> 32-bit, right?):
>
> ```
> TEST: java/uti
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Fri, 3 Nov 2023 18:43:31 GMT, Lance Andersen wrote:
> I can kick of a test run internally next week or perhaps Sunday
Thanks for your reviews, Lance and Iris!
FWIW, the test ran fine on Github Actions, including on `linux-x86` (which is
32-bit, right?):
TEST: java/util/zip/DataDescriptorS
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Mon, 30 Oct 2023 17:57:23 GMT, Eirik Bjorsnos wrote:
>> This way of updating the copyright was suggested by @jaikiran in the March
>> 10th comment above. Would be nice to get this clarified, yes.
>
> There is actually very little left of Martin's code after my rewrite, besides
> whitespace,
On Thu, 2 Nov 2023 18:21:07 GMT, Eirik Bjorsnos wrote:
> > Thinking some more about this, I would like to see us keep the Zip
> > generated by python, store it in a byte array (or equivalent) as it also
> > validate that we can still process the zip given this was the original test
> > and the
On Mon, 30 Oct 2023 19:54:12 GMT, Lance Andersen wrote:
> Thinking some more about this, I would like to see us keep the Zip generated
> by python, store it in a byte array (or equivalent) as it also validate that
> we can still process the zip given this was the original test and the zip is
>
On Mon, 30 Oct 2023 17:48:48 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Mon, 30 Oct 2023 17:45:28 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 3:
>>
>>> 1: /*
>>> 2: * Copyright 2012 Google, Inc. All Rights Reserved.
>>> 3: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
>>
>> I am not
On Mon, 30 Oct 2023 15:02:57 GMT, Lance Andersen wrote:
> Another question, is the zip that is generated by this test readable by other
> zip tools such as info-zip, Apache Common-compress, winzip?
- info-zip: Does not support unzipping from a zip, so uses the CEN instead of
the data descript
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
On Sat, 28 Oct 2023 20:01:56 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Sat, 28 Oct 2023 20:01:56 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
On Sat, 11 Mar 2023 08:27:06 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
On Fri, 10 Mar 2023 09:15:30 GMT, Jaikiran Pai wrote:
> This now looks good to me.
Thanks for taking time to do this thorough review and especially for running
the regressing case. Much appreciated!
I'll wait for a second review before integrating.
-
PR: https://git.openjdk.org/j
On Fri, 10 Mar 2023 08:48:00 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
On Fri, 10 Mar 2023 08:28:37 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
On Fri, 10 Mar 2023 08:14:56 GMT, Jaikiran Pai wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use "Signatureless" consistently
>
> test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 2:
>
>> 1: /*
>
On Fri, 10 Mar 2023 08:28:37 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
On Fri, 10 Mar 2023 08:06:58 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test
>> back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a
>> Data Descriptor without the recommended but optional signa
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature. The Python
> dependency has turned out to be very brittl
On Fri, 10 Mar 2023 07:47:05 GMT, Jaikiran Pai wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove reference to python in the @summary of
>> DataDescriptorSignatureMissing
>
> test/jdk/java/util/zip/DataDescr
On Thu, 9 Mar 2023 19:53:44 GMT, Eirik Bjorsnos wrote:
> Please review this PR which brings the DataDescriptorSignatureMissing test
> back to life.
>
> This test currently calls out to Python to create a test vector ZIP with a
> Data Descriptor without the recommended but optional signature.
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
Please review this PR which brings the DataDescript
33 matches
Mail list logo
