Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v3]

2023-03-14 Thread Daniel Jeliński
On Mon, 13 Mar 2023 15:55:27 GMT, Daniel Jeliński wrote: >> This patch modifies the `getLastErrorString` method to return a `jstring`. >> Thanks to that we can avoid unnecessary back and forth conversions between >> Unicode and other charsets on Windows. >> >> Other changes include: >> - the W

Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v3]

2023-03-14 Thread Julian Waters
On Mon, 13 Mar 2023 15:55:27 GMT, Daniel Jeliński wrote: >> This patch modifies the `getLastErrorString` method to return a `jstring`. >> Thanks to that we can avoid unnecessary back and forth conversions between >> Unicode and other charsets on Windows. >> >> Other changes include: >> - the W

Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v3]

2023-03-13 Thread Naoto Sato
On Mon, 13 Mar 2023 15:55:27 GMT, Daniel Jeliński wrote: >> This patch modifies the `getLastErrorString` method to return a `jstring`. >> Thanks to that we can avoid unnecessary back and forth conversions between >> Unicode and other charsets on Windows. >> >> Other changes include: >> - the W

Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v2]

2023-03-13 Thread Daniel Jeliński
On Mon, 13 Mar 2023 15:05:04 GMT, Roger Riggs wrote: >> Daniel Jeliński has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Address review comments >> - Mention that the returned text is static and thread safe >> - Define buffer size >

Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v3]

2023-03-13 Thread Daniel Jeliński
> This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows implementation of `getLastErrorString` no longer checks >

Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v2]

2023-03-13 Thread Roger Riggs
On Mon, 13 Mar 2023 09:48:19 GMT, Daniel Jeliński wrote: >> This patch modifies the `getLastErrorString` method to return a `jstring`. >> Thanks to that we can avoid unnecessary back and forth conversions between >> Unicode and other charsets on Windows. >> >> Other changes include: >> - the W

Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v2]

2023-03-13 Thread Daniel Jeliński
On Thu, 9 Mar 2023 18:08:32 GMT, Naoto Sato wrote: >> Daniel Jeliński has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Address review comments >> - Mention that the returned text is static and thread safe >> - Define buffer size > >

Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v2]

2023-03-13 Thread Daniel Jeliński
On Fri, 10 Mar 2023 21:47:45 GMT, Roger Riggs wrote: >> Daniel Jeliński has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Address review comments >> - Mention that the returned text is static and thread safe >> - Define buffer size >

Re: RFR: 8303814: getLastErrorString should avoid charset conversions [v2]

2023-03-13 Thread Daniel Jeliński
> This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows implementation of `getLastErrorString` no longer checks >

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-10 Thread Roger Riggs
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote: > This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-10 Thread Daniel Jeliński
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Thu, 9 Mar 2023 00:17:42 GMT, Naoto Sato wrote:

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-09 Thread Chris Plummer
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote: > This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-09 Thread Naoto Sato
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote: > This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-09 Thread Daniel Jeliński
On Wed, 8 Mar 2023 23:23:33 GMT, Chris Plummer wrote: >> This patch modifies the `getLastErrorString` method to return a `jstring`. >> Thanks to that we can avoid unnecessary back and forth conversions between >> Unicode and other charsets on Windows. >> >> Other changes include: >> - the Wind

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-08 Thread Chris Plummer
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote: > This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-08 Thread Daniel Jeliński
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote: > This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-08 Thread Naoto Sato
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote: > This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows

RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-08 Thread Daniel Jeliński
This patch modifies the `getLastErrorString` method to return a `jstring`. Thanks to that we can avoid unnecessary back and forth conversions between Unicode and other charsets on Windows. Other changes include: - the Windows implementation of `getLastErrorString` no longer checks `errno`. I ve