Re: RFR: 8303524: Check FunctionDescriptor byte order when linking

2023-03-28 Thread Jorn Vernee
On Thu, 23 Mar 2023 16:47:08 GMT, Jorn Vernee wrote: > Linkers are strongly tied to a particular byte order, because they are tied > to a particular platform. So, the linker should reject layouts that have > another byte order. This patch implements that check. I will fold this into https://gi

Re: RFR: 8303524: Check FunctionDescriptor byte order when linking

2023-03-27 Thread Jorn Vernee
On Thu, 23 Mar 2023 16:47:08 GMT, Jorn Vernee wrote: > Linkers are strongly tied to a particular byte order, because they are tied > to a particular platform. So, the linker should reject layouts that have > another byte order. This patch implements that check. > > > The code changes look good

Re: RFR: 8303524: Check FunctionDescriptor byte order when linking

2023-03-27 Thread Maurizio Cimadamore
On Mon, 27 Mar 2023 15:09:57 GMT, Jorn Vernee wrote: > > The code changes look good, but the javadoc should be updated to reflect > > the new constraints. > > We currently have this: > > ``` > @throws IllegalArgumentException if the provided function descriptor is not > supported by this link

Re: RFR: 8303524: Check FunctionDescriptor byte order when linking

2023-03-27 Thread Jorn Vernee
On Mon, 27 Mar 2023 14:44:10 GMT, Maurizio Cimadamore wrote: > The code changes look good, but the javadoc should be updated to reflect the > new constraints. We currently have this: @throws IllegalArgumentException if the provided function descriptor is not supported by this linker. Wh

Re: RFR: 8303524: Check FunctionDescriptor byte order when linking

2023-03-27 Thread Maurizio Cimadamore
On Thu, 23 Mar 2023 16:47:08 GMT, Jorn Vernee wrote: > Linkers are strongly tied to a particular byte order, because they are tied > to a particular platform. So, the linker should reject layouts that have > another byte order. This patch implements that check. The code changes look good, but

Re: RFR: 8303524: Check FunctionDescriptor byte order when linking

2023-03-27 Thread ExE Boss
On Thu, 23 Mar 2023 16:47:08 GMT, Jorn Vernee wrote: > Linkers are strongly tied to a particular byte order, because they are tied > to a particular platform. So, the linker should reject layouts that have > another byte order. This patch implements that check. src/java.base/share/classes/jdk/

Re: RFR: 8303524: Check FunctionDescriptor byte order when linking

2023-03-27 Thread Jorn Vernee
On Fri, 24 Mar 2023 08:02:05 GMT, ExE Boss wrote: >> Linkers are strongly tied to a particular byte order, because they are tied >> to a particular platform. So, the linker should reject layouts that have >> another byte order. This patch implements that check. > > src/java.base/share/classes/j

RFR: 8303524: Check FunctionDescriptor byte order when linking

2023-03-27 Thread Jorn Vernee
Linkers are strongly tied to a particular byte order, because they are tied to a particular platform. So, the linker should reject layouts that have another byte order. This patch implements that check. - Depends on: https://git.openjdk.org/jdk/pull/13079 Commit messages: - Check