On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote:
> `LinkedList` is used as a field
> `jdk.tools.jimage.JImageTask.OptionsValues#jimages`
> It's created, filled (with `add`) and then iterated. No removes from the head
> or something like this. `ArrayList` should be preferred as more effi
On Wed, 1 Mar 2023 01:32:39 GMT, Roger Riggs wrote:
>In choosing how you spend your time, make your efforts and the efforts of the
>reviewers count for something.
It's one of the reasons, why I don't create PRs with massive replacements. I
carefully choose places in the code, where I think rep
On Wed, 1 Mar 2023 01:32:39 GMT, Roger Riggs wrote:
> For this PR, go ahead and integrate, since we've already spent the budget for
> reviewing it.
I'm ok with this, as Roger said, since we've all already looked at it.
I'm not really interested in seeing 234 followup changes removing LinkedLis
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote:
> `LinkedList` is used as a field
> `jdk.tools.jimage.JImageTask.OptionsValues#jimages`
> It's created, filled (with `add`) and then iterated. No removes from the head
> or something like this. `ArrayList` should be preferred as more effi
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote:
> `LinkedList` is used as a field
> `jdk.tools.jimage.JImageTask.OptionsValues#jimages`
> It's created, filled (with `add`) and then iterated. No removes from the head
> or something like this. `ArrayList` should be preferred as more effi
On Mon, 27 Feb 2023 22:59:42 GMT, Roger Riggs wrote:
>> `LinkedList` is used as a field
>> `jdk.tools.jimage.JImageTask.OptionsValues#jimages`
>> It's created, filled (with `add`) and then iterated. No removes from the
>> head or something like this. `ArrayList` should be preferred as more
>>
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote:
> `LinkedList` is used as a field
> `jdk.tools.jimage.JImageTask.OptionsValues#jimages`
> It's created, filled (with `add`) and then iterated. No removes from the head
> or something like this. `ArrayList` should be preferred as more effi
On Mon, 27 Feb 2023 11:33:38 GMT, Andrey Turbanov wrote:
> `LinkedList` is used as a field
> `jdk.tools.jimage.JImageTask.OptionsValues#jimages`
> It's created, filled (with `add`) and then iterated. No removes from the head
> or something like this. `ArrayList` should be preferred as more effi
`LinkedList` is used as a field
`jdk.tools.jimage.JImageTask.OptionsValues#jimages`
It's created, filled (with `add`) and then iterated. No removes from the head
or something like this. `ArrayList` should be preferred as more efficient and
widely used (more chances for JIT) collection.
