On Tue, 2 May 2023 06:04:17 GMT, Alan Bateman wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Runtime.halt.
>
> Updated version, and the wording of halt's description, looks okay.
@AlanBateman Great. Can yo
On Tue, 2 May 2023 04:48:07 GMT, Stuart Marks wrote:
>> Textual specification clarifications.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update Runtime.halt.
Updated version, and the wording of halt's description, loo
> Textual specification clarifications.
Stuart Marks has updated the pull request incrementally with one additional
commit since the last revision:
Update Runtime.halt.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13706/files
- new: https://git.openjdk.org/jdk/pull/1370
On Mon, 1 May 2023 16:11:59 GMT, Stuart Marks wrote:
>> One thing you could do is reduce the words down to something like "Unless
>> denied exiting by the security manager, this method blocks indefinitely ..."
>> to avoid complicating the first paragraph with something that only arises
>> with
> Textual specification clarifications.
Stuart Marks has updated the pull request incrementally with two additional
commits since the last revision:
- Rewording per suggestions.
- Use new link syntax.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13706/files
- new: https
On Mon, 1 May 2023 05:33:00 GMT, Alan Bateman wrote:
>> Yeah I had some misgivings mentioning the SM first, but if it's not
>> mentioned, then the assertions in the rest of the text become hedged and
>> uncertain. The SM, checkExit, and whether the exit value is allowed all have
>> to be menti
On Fri, 28 Apr 2023 21:44:58 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/lang/Runtime.java line 146:
>>
>>> 144: * If a security manager is present and its {@link
>>> SecurityManager#checkExit checkExit}
>>> 145: * method disallows exiting with the specified status, t
On Fri, 28 Apr 2023 04:05:21 GMT, ExE Boss wrote:
>> Textual specification clarifications.
>
> src/java.base/share/classes/java/lang/Runtime.java line 143:
>
>> 141:
>> 142: /**
>> 143: * Initiates the shutdown sequence of the
>> Java Virtual Machine.
>
> Suggestion:
>
> * Init
On Fri, 28 Apr 2023 06:40:16 GMT, Alan Bateman wrote:
>> Textual specification clarifications.
>
> src/java.base/share/classes/java/lang/Runtime.java line 146:
>
>> 144: * If a security manager is present and its {@link
>> SecurityManager#checkExit checkExit}
>> 145: * method disallow
On Thu, 27 Apr 2023 23:06:42 GMT, Stuart Marks wrote:
> Textual specification clarifications.
src/java.base/share/classes/java/lang/Runtime.java line 146:
> 144: * If a security manager is present and its {@link
> SecurityManager#checkExit checkExit}
> 145: * method disallows exiting
On Thu, 27 Apr 2023 23:06:42 GMT, Stuart Marks wrote:
> Textual specification clarifications.
These can use the new generalised `@linkplain` tags available since **JDK 20**:
src/java.base/share/classes/java/lang/Runtime.java line 143:
> 141:
> 142: /**
> 143: * Initiates the shutdown
On Thu, 27 Apr 2023 23:06:42 GMT, Stuart Marks wrote:
> Textual specification clarifications.
Please review CSR [JDK-8307081](https://bugs.openjdk.org/browse/JDK-8307081).
-
PR Comment: https://git.openjdk.org/jdk/pull/13706#issuecomment-1526712106
Textual specification clarifications.
-
Commit messages:
- 8302496: Runtime.exit incorrectly says it never throws an exception
Changes: https://git.openjdk.org/jdk/pull/13706/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13706&range=00
Issue: https://bugs.openjdk.org/bro
13 matches
Mail list logo
