Re: RFR: 8301120: Cleanup utility classes java.util.Arrays and java.util.Collections [v2]

2023-01-27 Thread Joe Darcy
On Wed, 25 Jan 2023 22:23:26 GMT, Tagir F. Valeev wrote: >> number of minor cleanups could be done in Arrays and Collections utility >> classes. >> In Arrays: >> - Redundant import jdk.internal.misc.Unsafe; >> - C-style array declaration is used in public static boolean equals(short[] >> a, sho

Re: RFR: 8301120: Cleanup utility classes java.util.Arrays and java.util.Collections [v2]

2023-01-27 Thread Stuart Marks
On Wed, 25 Jan 2023 22:23:26 GMT, Tagir F. Valeev wrote: >> number of minor cleanups could be done in Arrays and Collections utility >> classes. >> In Arrays: >> - Redundant import jdk.internal.misc.Unsafe; >> - C-style array declaration is used in public static boolean equals(short[] >> a, sho

Re: RFR: 8301120: Cleanup utility classes java.util.Arrays and java.util.Collections [v2]

2023-01-26 Thread Joe Darcy
On Fri, 27 Jan 2023 00:19:49 GMT, Stuart Marks wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert cast removal > > src/java.base/share/classes/java/util/Collections.java line 1068: > >> 1066: >> 1067:

Re: RFR: 8301120: Cleanup utility classes java.util.Arrays and java.util.Collections [v2]

2023-01-26 Thread Stuart Marks
On Wed, 25 Jan 2023 22:23:26 GMT, Tagir F. Valeev wrote: >> number of minor cleanups could be done in Arrays and Collections utility >> classes. >> In Arrays: >> - Redundant import jdk.internal.misc.Unsafe; >> - C-style array declaration is used in public static boolean equals(short[] >> a, sho

Re: RFR: 8301120: Cleanup utility classes java.util.Arrays and java.util.Collections [v2]

2023-01-26 Thread Stuart Marks
On Wed, 25 Jan 2023 22:23:26 GMT, Tagir F. Valeev wrote: >> number of minor cleanups could be done in Arrays and Collections utility >> classes. >> In Arrays: >> - Redundant import jdk.internal.misc.Unsafe; >> - C-style array declaration is used in public static boolean equals(short[] >> a, sho

Re: RFR: 8301120: Cleanup utility classes java.util.Arrays and java.util.Collections [v2]

2023-01-25 Thread Tagir F . Valeev
> number of minor cleanups could be done in Arrays and Collections utility > classes. > In Arrays: > - Redundant import jdk.internal.misc.Unsafe; > - C-style array declaration is used in public static boolean equals(short[] > a, short a2[]) (that's the only place in the whole file) > > In Collec

RFR: 8301120: Cleanup utility classes java.util.Arrays and java.util.Collections

2023-01-25 Thread Tagir F . Valeev
number of minor cleanups could be done in Arrays and Collections utility classes. In Arrays: - Redundant import jdk.internal.misc.Unsafe; - C-style array declaration is used in public static boolean equals(short[] a, short a2[]) (that's the only place in the whole file) - Redundant casts to Objec