On Tue, 28 Mar 2023 18:15:57 GMT, Eirik Bjorsnos wrote:
> > @eirbjo I've updated the PR so we hold zero-length arrays rather than null
> > arrays. Please re-run your benchmark to see if there is any change.
>
> @minborg I ran the test now after your integration and I no longer observe
> the re
On Thu, 23 Mar 2023 14:00:40 GMT, Eirik Bjorsnos wrote:
>> I cannot explain why, but the changes suggested in this PR seem to introduce
>> a small, but significant performance regression on the
>> `DataInputStreamTest.readInt` benchmark:
>>
>> Baseline:
>>
>>
>> Benchmark
On Thu, 23 Mar 2023 14:00:40 GMT, Eirik Bjorsnos wrote:
>> I cannot explain why, but the changes suggested in this PR seem to introduce
>> a small, but significant performance regression on the
>> `DataInputStreamTest.readInt` benchmark:
>>
>> Baseline:
>>
>>
>> Benchmark
On Wed, 22 Mar 2023 10:12:26 GMT, Per Minborg wrote:
>> This PR proposed to lazily initialize the scratch arrays only if/when needed.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought
On Thu, 23 Mar 2023 13:51:35 GMT, Eirik Bjorsnos wrote:
> The reason this puzzles me is that the `readInt` benchmark don't involve the
> UTF code paths at all. So why would it become slower, just because two fields
> are no longer initialized with the default arrays?
Could there be some JIT op
On Wed, 22 Mar 2023 10:12:26 GMT, Per Minborg wrote:
>> This PR proposed to lazily initialize the scratch arrays only if/when needed.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought
On Wed, 22 Mar 2023 10:12:26 GMT, Per Minborg wrote:
>> This PR proposed to lazily initialize the scratch arrays only if/when needed.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought
On Wed, 22 Mar 2023 10:07:57 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/io/DataInputStream.java line 64:
>>
>>> 62: * working arrays initialized on demand by readUTF
>>> 63: */
>>> 64: private byte[] bytearr;
>>
>> Could the `bytearr` and `chararr` instance variab
> This PR proposed to lazily initialize the scratch arrays only if/when needed.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains five additio
On Tue, 21 Mar 2023 16:17:35 GMT, Brian Burkhalter wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> comm
10 matches
Mail list logo
