Re: RFR: 8300866: Declare some classes final in java.io [v2]

2023-01-23 Thread Per Minborg
> This PR proposes declaring some internal classes in java.io as `final`, > explicitly indicating that they are not intended for sub-classing. > > If you think declaring classes final is just "static noice", please see > http://minborgsjavapot.blogspot.com/2021/12/why-general-inheritance-is-fla

Re: RFR: 8300866: Declare some classes final in java.io

2023-01-23 Thread Alan Bateman
On Mon, 23 Jan 2023 18:06:26 GMT, Per Minborg wrote: > It looks like CE is used in `UnixFileSystem` via the system property > "sun.io.useCanonCaches" ? It was disabled in JDK 12 and the general plan was to eventually remove it eventually. - PR: https://git.openjdk.org/jdk/pull/12

Re: RFR: 8300866: Declare some classes final in java.io

2023-01-23 Thread Per Minborg
On Mon, 23 Jan 2023 18:02:44 GMT, Alan Bateman wrote: > Look okay. We should probably think about removing ExpiringCache as it hasn't > been used for many releases. It looks like CE is used in `UnixFileSystem` via the system property "sun.io.useCanonCaches" ? - PR: https://git.op

Re: RFR: 8300866: Declare some classes final in java.io

2023-01-23 Thread Alan Bateman
On Mon, 23 Jan 2023 14:40:50 GMT, Per Minborg wrote: > This PR proposes declaring some internal classes in java.io as `final`, > explicitly indicating that they are not intended for sub-classing. > > If you think declaring classes final is just "static noice", please see > http://minborgsjava

RFR: 8300866: Declare some classes final in java.io

2023-01-23 Thread Per Minborg
This PR proposes declaring some internal classes in java.io as `final`, explicitly indicating that they are not intended for sub-classing. If you think declaring classes final is just "static noice", please see http://minborgsjavapot.blogspot.com/2021/12/why-general-inheritance-is-flawed-and.ht