Re: RFR: 8300864: Declare some fields in java.io as final

2023-01-23 Thread Alan Bateman
On Mon, 23 Jan 2023 14:24:16 GMT, Per Minborg wrote: > Some of the fields in java.io can be declared as final. src/java.base/share/classes/java/io/File.java line 155: > 153: * The FileSystem object representing the platform's local file > system. > 154: */ > 155: private static f

Re: RFR: 8300864: Declare some fields in java.io as final

2023-01-23 Thread Lance Andersen
On Mon, 23 Jan 2023 14:24:16 GMT, Per Minborg wrote: > Some of the fields in java.io can be declared as final. The changes look reasonable to me - Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.org/jdk/pull/12140

Re: RFR: 8300864: Declare some fields in java.io as final

2023-01-23 Thread Roger Riggs
On Mon, 23 Jan 2023 14:24:16 GMT, Per Minborg wrote: > Some of the fields in java.io can be declared as final. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12140

RFR: 8300864: Declare some fields in java.io as final

2023-01-23 Thread Per Minborg
Some of the fields in java.io can be declared as final. - Commit messages: - Revert final class declaration - Declare fields final Changes: https://git.openjdk.org/jdk/pull/12140/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12140&range=00 Issue: https://bugs.openjdk.or