Re: RFR: 8300794: Use @snippet in java.util:i18n [v3]

2023-05-15 Thread Justin Lu
> Please review this javadoc only change which uses `@snippet` and `@linkplain` > in i18n related util packages. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Use elipsis replacement in snippet tag recommended in JDK PR #13957 --

Re: RFR: 8300794: Use @snippet in java.util:i18n [v2]

2023-05-12 Thread Lance Andersen
On Thu, 11 May 2023 20:39:57 GMT, Justin Lu wrote: >> Please review this javadoc only change which uses `@snippet` and >> `@linkplain` in i18n related util packages. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Review: Mov

Re: RFR: 8300794: Use @snippet in java.util:i18n [v2]

2023-05-12 Thread Naoto Sato
On Thu, 11 May 2023 20:39:57 GMT, Justin Lu wrote: >> Please review this javadoc only change which uses `@snippet` and >> `@linkplain` in i18n related util packages. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Review: Mov

Re: RFR: 8300794: Use @snippet in java.util:i18n [v2]

2023-05-11 Thread Justin Lu
On Thu, 11 May 2023 20:21:55 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review: Move links on top, fix indentation in example > > src/java.base/share/classes/java/util/ResourceBundle.java line 512

Re: RFR: 8300794: Use @snippet in java.util:i18n [v2]

2023-05-11 Thread Justin Lu
> Please review this javadoc only change which uses `@snippet` and `@linkplain` > in i18n related util packages. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Review: Move links on top, fix indentation in example - Chang

Re: RFR: 8300794: Use @snippet in java.util:i18n

2023-05-11 Thread Naoto Sato
On Wed, 10 May 2023 23:54:37 GMT, Justin Lu wrote: > Please review this javadoc only change which uses `@snippet` and `@linkplain` > in i18n related util packages. Looks good overall. Some minor comments follow. src/java.base/share/classes/java/util/Currency.java line 517: > 515: * If th

RFR: 8300794: Use @snippet in java.util:i18n

2023-05-10 Thread Justin Lu
Please review this javadoc only change which uses `@snippet` and `@linkplain` in i18n related util packages. - Commit messages: - copyright years - property resource bundle changes - list resource bundle changes - resource bundle changes - currency changes - locale changes Cha