Re: RFR: 8300586: Refactor code examples to use @snippet in java.text.Collator

2023-01-18 Thread Naoto Sato
On Wed, 18 Jan 2023 19:36:51 GMT, Justin Lu wrote: > This PR implements _JEP 413: Code Snippets in Java API Documentation_ for > [java.text.Collator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/Collator.html). > > Code examples using ... blocks are replaced with the

Re: RFR: 8300586: Refactor code examples to use @snippet in java.text.Collator

2023-01-18 Thread Lance Andersen
On Wed, 18 Jan 2023 19:36:51 GMT, Justin Lu wrote: > This PR implements _JEP 413: Code Snippets in Java API Documentation_ for > [java.text.Collator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/Collator.html). > > Code examples using ... blocks are replaced with the

Re: RFR: 8300586: Refactor code examples to use @snippet in java.text.Collator

2023-01-18 Thread Justin Lu
On Wed, 18 Jan 2023 21:07:01 GMT, Iris Clark wrote: >> The first `}` is for closing the else statement and the second `}` is for >> closing the `{snippet` > > I see that now! I didn't look up far enough. Thanks! No worries, thank you for reviewing! - PR: https://git.openjdk.org/

Re: RFR: 8300586: Refactor code examples to use @snippet in java.text.Collator

2023-01-18 Thread Iris Clark
On Wed, 18 Jan 2023 20:43:37 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/text/Collator.java line 83: >> >>> 81: * System.out.println("abc is greater than or equal to ABC"); >>> 82: * } >>> 83: * } >> >> I don't think you need a second '}' here. > > The first `}` is for clos

Re: RFR: 8300586: Refactor code examples to use @snippet in java.text.Collator

2023-01-18 Thread Justin Lu
On Wed, 18 Jan 2023 20:19:03 GMT, Iris Clark wrote: >> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for >> [java.text.Collator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/Collator.html). >> >> Code examples using ... blocks are replaced wit

Re: RFR: 8300586: Refactor code examples to use @snippet in java.text.Collator

2023-01-18 Thread Iris Clark
On Wed, 18 Jan 2023 19:36:51 GMT, Justin Lu wrote: > This PR implements _JEP 413: Code Snippets in Java API Documentation_ for > [java.text.Collator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/Collator.html). > > Code examples using ... blocks are replaced with the

RFR: 8300586: Refactor code examples to use @snippet in java.text.Collator

2023-01-18 Thread Justin Lu
This PR implements _JEP 413: Code Snippets in Java API Documentation_ for [java.text.Collator](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/Collator.html). Code examples using ... blocks are replaced with the @ snippet syntax where applicable. Additionally, the code