Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v2]

2023-02-09 Thread David Holmes
On Thu, 9 Feb 2023 11:03:44 GMT, Varada M wrote: > These tests is passing without adding lpthread in JtregNativeHotspot.gmk. Do > I need to update the makefile? I'm somewhat surprised that the tests pass without explicit linkage, but perhaps libpthread is a default on AIX. If things are workin

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v4]

2023-02-09 Thread Thomas Stuefe
On Thu, 9 Feb 2023 13:46:05 GMT, Varada M wrote: >> 1. test/jdk/jni/nullCaller/NullCallerTest.java >> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java >> >> The above tests were blocked on AIX [@req

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v4]

2023-02-09 Thread Varada M
On Thu, 9 Feb 2023 11:30:11 GMT, Thomas Stuefe wrote: >> Varada M has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixes > > test/jdk/jni/nullCaller/exeNullCallerTest.cpp line 159: > >> 157: } >> 158: >> 159: int main(int argc, char** a

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v4]

2023-02-09 Thread Varada M
> 1. test/jdk/jni/nullCaller/NullCallerTest.java > 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java > > The above tests were blocked on AIX [@require os.family != "aix"] because > these tests are fail

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v3]

2023-02-09 Thread Thomas Stuefe
On Thu, 9 Feb 2023 11:17:54 GMT, Varada M wrote: >> 1. test/jdk/jni/nullCaller/NullCallerTest.java >> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java >> >> The above tests were blocked on AIX [@req

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v3]

2023-02-09 Thread Thomas Stuefe
On Thu, 9 Feb 2023 11:28:47 GMT, Thomas Stuefe wrote: >> Varada M has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixes > > test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c line 48: > >> 46: int checkAccess(JNIEnv *e

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v2]

2023-02-09 Thread Varada M
On Wed, 8 Feb 2023 15:53:52 GMT, Tyler Steele wrote: >> Varada M has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixes > > test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java line 2: > >> 1: /* >> 2: * Copyright (c) 2021, 2

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v3]

2023-02-09 Thread Varada M
> 1. test/jdk/jni/nullCaller/NullCallerTest.java > 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java > > The above tests were blocked on AIX [@require os.family != "aix"] because > these tests are fail

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v2]

2023-02-09 Thread Varada M
On Wed, 8 Feb 2023 21:30:29 GMT, David Holmes wrote: > It just occurred to me that we may also need to update the test makefiles to > link to libpthread for these modified tests? Running test 'jtreg:test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java' Passed: runtime/jni/CalleeSav

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v2]

2023-02-08 Thread David Holmes
On Wed, 8 Feb 2023 13:11:25 GMT, Varada M wrote: >> 1. test/jdk/jni/nullCaller/NullCallerTest.java >> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java >> >> The above tests were blocked on AIX [@req

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v2]

2023-02-08 Thread Tyler Steele
On Wed, 8 Feb 2023 13:11:25 GMT, Varada M wrote: >> 1. test/jdk/jni/nullCaller/NullCallerTest.java >> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java >> >> The above tests were blocked on AIX [@req

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v2]

2023-02-08 Thread Thomas Stuefe
On Wed, 8 Feb 2023 11:33:07 GMT, Varada M wrote: > I hate to see the code duplication, but we don't have a sharing mechanism for > the native parts of tests so that can't be helped. It may be interesting to invest some time to find out if the "don't start on primordial thread" rule still holds

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread [v2]

2023-02-08 Thread Varada M
> 1. test/jdk/jni/nullCaller/NullCallerTest.java > 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java > > The above tests were blocked on AIX [@require os.family != "aix"] because > these tests are fail

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread

2023-02-08 Thread Varada M
On Wed, 8 Feb 2023 11:37:14 GMT, Alan Bateman wrote: >> 1. test/jdk/jni/nullCaller/NullCallerTest.java >> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java >> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java >> >> The above tests were blocked on AIX [

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread

2023-02-08 Thread Alan Bateman
On Tue, 31 Jan 2023 05:24:35 GMT, Varada M wrote: > 1. test/jdk/jni/nullCaller/NullCallerTest.java > 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java > > The above tests were blocked on AIX [@require

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread

2023-02-08 Thread Varada M
On Wed, 8 Feb 2023 11:03:35 GMT, David Holmes wrote: > I hate to see the code duplication, but we don't have a sharing mechanism for > the native parts of tests so that can't be helped. > > Changes look good. > > Please update the Oracle copyright lines so that the second year is 2023 if > ne

Re: RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread

2023-02-08 Thread David Holmes
On Tue, 31 Jan 2023 05:24:35 GMT, Varada M wrote: > 1. test/jdk/jni/nullCaller/NullCallerTest.java > 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java > 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java > > The above tests were blocked on AIX [@require

RFR: 8300139 : [AIX] Use pthreads to avoid JNI_createVM call from primordial thread

2023-02-07 Thread Varada M
1. test/jdk/jni/nullCaller/NullCallerTest.java 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java The above tests were blocked on AIX [@require os.family != "aix"] because these tests are failing to call