Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread [v3]

2022-11-26 Thread Ryan Ernst
On Sat, 26 Nov 2022 17:24:02 GMT, Alan Bateman wrote: > Not important but can eliminate the casts from privilegedThreadSetXXX methods > if you separate the creation of the PrivilegedAction from the doPriv call. I chose to keep it as is since there was already another doPriv in the file that us

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread [v3]

2022-11-26 Thread Alan Bateman
On Sat, 26 Nov 2022 15:55:27 GMT, Ryan Ernst wrote: >> This commit guards thread modifications for the process reaper thread with >> doPrivileged. > > Ryan Ernst has updated the pull request incrementally with one additional > commit since the last revision: > > Revert factory method This l

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread [v3]

2022-11-26 Thread Chris Hegarty
On Wed, 23 Nov 2022 16:02:37 GMT, Chris Hegarty wrote: >> I would prefer to to avoid creating new factories when the desired function >> can be done on the resulting thread. >> Such as `setDaemon()` and `setName()`, etc. >> It does avoid the doPriv in this case, but is not necessary and when the

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread [v3]

2022-11-26 Thread Chris Hegarty
On Sat, 26 Nov 2022 15:50:54 GMT, Ryan Ernst wrote: >> This commit guards thread modifications for the process reaper thread with >> doPrivileged. > > Ryan Ernst has updated the pull request incrementally with one additional > commit since the last revision: > > Revert factory method LGTM

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread [v3]

2022-11-26 Thread Ryan Ernst
> This commit guards thread modifications for the process reaper thread with > doPrivileged. Ryan Ernst has updated the pull request incrementally with one additional commit since the last revision: Revert factory method - Changes: - all: https://git.openjdk.org/jdk/pull/11309

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread [v2]

2022-11-26 Thread Ryan Ernst
> This commit guards thread modifications for the process reaper thread with > doPrivileged. Ryan Ernst has updated the pull request incrementally with two additional commits since the last revision: - Merge pull request #1 from ChrisHegarty/reaper_thread_modify Add privileged helper me

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread

2022-11-23 Thread Chris Hegarty
On Wed, 23 Nov 2022 15:22:47 GMT, Roger Riggs wrote: >> src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 137: >> >>> 135: public static Thread newSystemThread(String name, Runnable target, >>> 136: long stackSize, int priority,

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread

2022-11-23 Thread Roger Riggs
On Wed, 23 Nov 2022 08:38:02 GMT, Chris Hegarty wrote: >> This commit guards thread modifications for the process reaper thread with >> doPrivileged. > > src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 137: > >> 135: public static Thread newSystemThread(String name,

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread

2022-11-23 Thread Chris Hegarty
On Wed, 23 Nov 2022 05:01:40 GMT, Ryan Ernst wrote: > This commit guards thread modifications for the process reaper thread with > doPrivileged. Changes requested by chegar (Reviewer). src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 137: > 135: public static Thread

Re: RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread

2022-11-23 Thread Chris Hegarty
On Wed, 23 Nov 2022 05:01:40 GMT, Ryan Ernst wrote: > This commit guards thread modifications for the process reaper thread with > doPrivileged. Hi @rjernst Thanks for taking this one on. I agree with adding the privileged blocks around the calls to Thread::setName, but the usage raises a wa

RFR: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread

2022-11-22 Thread Ryan Ernst
This commit guards thread modifications for the process reaper thread with doPrivileged. - Commit messages: - 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread Changes: https://git.openjdk.org/jdk/pull/11309/files Webrev: https://webrevs.openjdk.org/