Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v7]

2025-05-01 Thread Chen Liang
On Wed, 30 Apr 2025 22:12:20 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. This is useful for clients like javap to report the correct >> undefined flags for different class file versions. >> >> A preparatory patch for javap

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v7]

2025-05-01 Thread Roger Riggs
On Wed, 30 Apr 2025 22:12:20 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. This is useful for clients like javap to report the correct >> undefined flags for different class file versions. >> >> A preparatory patch for javap

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v7]

2025-04-30 Thread Chen Liang
> Take the class file version to reject flags not yet defined, redefined, or > obsoleted. This is useful for clients like javap to report the correct > undefined flags for different class file versions. > > A preparatory patch for javap to pass around the ClassFileFormatVersion to > parse flags

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v6]

2025-04-30 Thread Chen Liang
On Wed, 30 Apr 2025 18:17:27 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. This is useful for clients like javap to report the correct >> undefined flags for different class file versions. >> >> A preparatory patch for javap

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v6]

2025-04-30 Thread Roger Riggs
On Wed, 30 Apr 2025 18:17:27 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. This is useful for clients like javap to report the correct >> undefined flags for different class file versions. >> >> A preparatory patch for javap

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v6]

2025-04-30 Thread Chen Liang
> Take the class file version to reject flags not yet defined, redefined, or > obsoleted. This is useful for clients like javap to report the correct > undefined flags for different class file versions. > > A preparatory patch for javap to pass around the ClassFileFormatVersion to > parse flags

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v5]

2025-04-30 Thread Chen Liang
On Tue, 29 Apr 2025 19:48:01 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. This is useful for clients like javap to report the correct >> undefined flags for different class file versions. >> >> A preparatory patch for javap

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v4]

2025-04-29 Thread Roger Riggs
On Tue, 29 Apr 2025 20:01:23 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 401: >> >>> 399: public static Set maskToAccessFlags(int mask, Location >>> location, ClassFileFormatVersion cffv) { >>> 400: var definition = findDefinition(loc

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v5]

2025-04-29 Thread Roger Riggs
On Tue, 29 Apr 2025 19:59:46 GMT, Chen Liang wrote: > Unfortunately the cffv-aware maskToAccessFlags introduction and old > maskToAccessFlags migration to reject STRICTFP are bundled together - this > means javap will need an ad-hoc facility to parse instead of using these > APIs. Is that the

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v5]

2025-04-29 Thread Chen Liang
On Tue, 29 Apr 2025 19:48:01 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. The non-cffv version can return the preview flags when the >> current runtime is in preview. > > Chen Liang has updated the pull request with a new tar

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v4]

2025-04-29 Thread Chen Liang
On Tue, 29 Apr 2025 19:41:23 GMT, Roger Riggs wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 10 commits: >> >> - Wording updates >> - Merge branch 'feature/af-location-accessors' into feature/af-cffv-parse

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v4]

2025-04-29 Thread Roger Riggs
On Tue, 29 Apr 2025 16:12:01 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. The non-cffv version can return the preview flags when the >> current runtime is in preview. > > Chen Liang has updated the pull request with a new tar

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v5]

2025-04-29 Thread Roger Riggs
On Tue, 29 Apr 2025 19:48:01 GMT, Chen Liang wrote: >> Take the class file version to reject flags not yet defined, redefined, or >> obsoleted. The non-cffv version can return the preview flags when the >> current runtime is in preview. > > Chen Liang has updated the pull request with a new tar

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v5]

2025-04-29 Thread Chen Liang
> Take the class file version to reject flags not yet defined, redefined, or > obsoleted. The non-cffv version can return the preview flags when the current > runtime is in preview. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now c

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v4]

2025-04-29 Thread Chen Liang
> Take the class file version to reject flags not yet defined, redefined, or > obsoleted. The non-cffv version can return the preview flags when the current > runtime is in preview. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now c

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v3]

2025-04-26 Thread Chen Liang
> Take the class file version to reject flags not yet defined, redefined, or > obsoleted. The non-cffv version can return the preview flags when the current > runtime is in preview. Chen Liang has updated the pull request incrementally with two additional commits since the last revision: - Mi

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version [v2]

2025-04-26 Thread Chen Liang
> Take the class file version to reject flags not yet defined, redefined, or > obsoleted. The non-cffv version can return the preview flags when the current > runtime is in preview. Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now c

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version

2025-04-19 Thread Chen Liang
On Fri, 18 Apr 2025 20:33:27 GMT, Chen Liang wrote: > Take the class file version to reject flags not yet defined, redefined, or > obsoleted. The non-cffv version can return the preview flags when the current > runtime is in preview. That is tracked in a separate bug linked as a dependent on t

Re: RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version

2025-04-19 Thread ExE Boss
On Fri, 18 Apr 2025 20:33:27 GMT, Chen Liang wrote: > Take the class file version to reject flags not yet defined, redefined, or > obsoleted. The non-cffv version can return the preview flags when the current > runtime is in preview. With this, the **Class‑File API** needs to be updated to pas

RFR: 8297271: AccessFlag.maskToAccessFlags should be specific to class file version

2025-04-18 Thread Chen Liang
Take the class file version to reject flags not yet defined, redefined, or obsoleted. The non-cffv version can return the preview flags when the current runtime is in preview. - Depends on: https://git.openjdk.org/jdk/pull/23095 Commit messages: - 8297271: AccessFlag.maskToAccessF