Re: RFR: 8296431 - PushbackInputStream should override transferTo [v5]

2022-11-11 Thread Brian Burkhalter
On Wed, 9 Nov 2022 07:11:53 GMT, Markus KARG wrote: >> This PR implements JDK-8296431 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Removed unused imports Marked as reviewed by bpb (Reviewer). - PR: https://

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-11 Thread Markus KARG
On Fri, 11 Nov 2022 12:32:10 GMT, Alan Bateman wrote: > I don't have any other comments. @bplb told me that he would sponsor this for > you. Thanks, but I need a successful review logged first. :-) - PR: https://git.openjdk.org/jdk/pull/10999

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-11 Thread Alan Bateman
On Mon, 7 Nov 2022 14:24:18 GMT, Markus KARG wrote: > @AlanBateman I fixed what you asked for. Kindly requesting review. :-) I don't have any other comments. @bplb told me that he would sponsor this for you. - PR: https://git.openjdk.org/jdk/pull/10999

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v5]

2022-11-10 Thread Markus KARG
On Wed, 9 Nov 2022 07:11:53 GMT, Markus KARG wrote: >> This PR implements JDK-8296431 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Removed unused imports @bplb Is there more you like to get changed? - PR: h

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v5]

2022-11-08 Thread Markus KARG
> This PR implements JDK-8296431 Markus KARG has updated the pull request incrementally with one additional commit since the last revision: Removed unused imports - Changes: - all: https://git.openjdk.org/jdk/pull/10999/files - new: https://git.openjdk.org/jdk/pull/10999/file

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-08 Thread Markus KARG
On Mon, 7 Nov 2022 17:29:15 GMT, Brian Burkhalter wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed typo > > test/jdk/java/io/PushbackInputStream/TransferTo.java line 24: > >> 22: */ >> 23: >> 24: import java

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-07 Thread Brian Burkhalter
On Sat, 5 Nov 2022 18:29:47 GMT, Markus KARG wrote: >> This PR implements JDK-8296431 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > fixed typo test/jdk/java/io/PushbackInputStream/TransferTo.java line 24: > 22: */ > 23:

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-07 Thread Markus KARG
On Sat, 5 Nov 2022 18:29:47 GMT, Markus KARG wrote: >> This PR implements JDK-8296431 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > fixed typo @AlanBateman I fixed what you asked for. Kindly requesting review. :-) --

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v3]

2022-11-05 Thread Markus KARG
On Sat, 5 Nov 2022 17:13:14 GMT, Alan Bateman wrote: >> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Removing synchronization >> - Renamed lock back to closeLock > > src/java.base/share/classes/java/io/PushbackInputStre

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v4]

2022-11-05 Thread Markus KARG
> This PR implements JDK-8296431 Markus KARG has updated the pull request incrementally with one additional commit since the last revision: fixed typo - Changes: - all: https://git.openjdk.org/jdk/pull/10999/files - new: https://git.openjdk.org/jdk/pull/10999/files/f7ee1c7a..

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v3]

2022-11-05 Thread Alan Bateman
On Sat, 5 Nov 2022 08:50:53 GMT, Markus KARG wrote: >> This PR implements JDK-8296431 > > Markus KARG has updated the pull request incrementally with two additional > commits since the last revision: > > - Removing synchronization > - Renamed lock back to closeLock src/java.base/share/classe

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v2]

2022-11-05 Thread Markus KARG
On Sat, 5 Nov 2022 07:19:32 GMT, Alan Bateman wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed wrong bug number > > src/java.base/share/classes/java/io/PushbackInputStream.java line 416: > >> 414: Obje

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v3]

2022-11-05 Thread Markus KARG
> This PR implements JDK-8296431 Markus KARG has updated the pull request incrementally with two additional commits since the last revision: - Removing synchronization - Renamed lock back to closeLock - Changes: - all: https://git.openjdk.org/jdk/pull/10999/files - new: https

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v2]

2022-11-05 Thread Alan Bateman
On Fri, 4 Nov 2022 22:24:57 GMT, Markus KARG wrote: >> This PR implements JDK-8296431 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > fixed wrong bug number src/java.base/share/classes/java/io/PushbackInputStream.java line

Re: RFR: 8296431 - PushbackInputStream should override transferTo [v2]

2022-11-04 Thread Markus KARG
> This PR implements JDK-8296431 Markus KARG has updated the pull request incrementally with one additional commit since the last revision: fixed wrong bug number - Changes: - all: https://git.openjdk.org/jdk/pull/10999/files - new: https://git.openjdk.org/jdk/pull/10999/file

RFR: 8296431 - PushbackInputStream should override transferTo

2022-11-04 Thread Markus KARG
This PR implements JDK-8296431 - Commit messages: - Alternative C + Array.copyOfRange - Draft: Prevent security issues - wrapped long code lines - removed unused import - Writing available unread bytes in the optimized case - PushbackInputStream::transferTo Changes: https://git