Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java [v2]

2022-10-31 Thread Naoto Sato
On Mon, 31 Oct 2022 17:50:47 GMT, Justin Lu wrote: >> Issue: Duplication of methods between Basic*.java test classes, due to auto >> generation by genBasic.sh >> >> Fix: Reorganize parts of Basic-X.java.template into base class in >> Basic.java. Toggled -nel flag for generation script (genBasi

Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java [v2]

2022-10-31 Thread Lance Andersen
On Mon, 31 Oct 2022 17:50:47 GMT, Justin Lu wrote: >> Issue: Duplication of methods between Basic*.java test classes, due to auto >> generation by genBasic.sh >> >> Fix: Reorganize parts of Basic-X.java.template into base class in >> Basic.java. Toggled -nel flag for generation script (genBasi

Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java [v2]

2022-10-31 Thread Justin Lu
On Sat, 29 Oct 2022 18:05:50 GMT, Сергей Цыпанов wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove old ids hack, has no usage > > test/jdk/java/util/Formatter/Basic-X.java.template line 1608: > >> 1606:

Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java [v2]

2022-10-31 Thread Justin Lu
On Fri, 28 Oct 2022 22:43:34 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove old ids hack, has no usage > > test/jdk/java/util/Formatter/Basic-X.java.template line 1612: > >> 1610: list

Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java [v2]

2022-10-31 Thread Justin Lu
> Issue: Duplication of methods between Basic*.java test classes, due to auto > generation by genBasic.sh > > Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. > Toggled -nel flag for generation script (genBasic.sh) to remove excessive > white space. Moved a previous