On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote:
> Modified 3 of 3 test/jdk/tools/jlink test classes to replace
> com.sun.tools.classfile library.
Marked as reviewed by ksakata (Committer).
I'll sponsor you. I've checked those tests passed.
-
PR Review: https://git.openjdk.org/
On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote:
> Modified 3 of 3 test/jdk/tools/jlink test classes to replace
> com.sun.tools.classfile library.
Looks good.
-
Marked as reviewed by mchung (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14877#pullrequestreview-15509595
On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote:
> Modified 3 of 3 test/jdk/tools/jlink test classes to replace
> com.sun.tools.classfile library.
I would suggest to minimise footprint of the patch and do not change unrelated
code.
Any unnecessary reformat can cause conflicts when merging in
On Sun, 16 Jul 2023 12:37:44 GMT, Chen Liang wrote:
> I think these exports can probably be removed completely; no test code uses
> ASM, meaning the export was likely redundant from the very beginning.
I can confirm, the tests are passing even without the exports.
-
PR Comment: ht
Modified 3 of 3 test/jdk/tools/jlink test classes to replace
com.sun.tools.classfile library.
-
Commit messages:
- Dropped unnecessary exports.
- Rollback the original format
- 8294979: test/jdk/tools/jlink 3 test classes use ASM library
Changes: https://git.openjdk.org/jdk/pull/
On Thu, 13 Jul 2023 18:35:42 GMT, Qing Xiao wrote:
> Modified 3 of 3 test/jdk/tools/jlink test classes to replace
> com.sun.tools.classfile library.
I think these exports can probably be removed completely; no test code uses
ASM, meaning the export was likely redundant from the very beginning.
