Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v16]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: adding servicea

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v15]

On Fri, 15 Sep 2023 09:42:24 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v15]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixed TestClass

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v14]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 233

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v13]

On Thu, 14 Sep 2023 16:38:36 GMT, Brian Goetz wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> applied suggested changes from review > > src/java.base/share/classes/jdk/internal/classfile/ClassReader.java line 184: >

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v13]

On Fri, 8 Sep 2023 10:15:26 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with o

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Thu, 7 Sep 2023 03:10:33 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into JDK-8294969-

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v13]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: applied suggest

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target b

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v12]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 229

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Wed, 6 Sep 2023 19:53:12 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into JDK-8294969-

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Wed, 6 Sep 2023 19:57:19 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into JDK-8294969-

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Wed, 6 Sep 2023 19:55:49 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 227 commits: >> >> - Merge branch 'master' into JDK-8294969-javap >> - Merge branch 'master' into JDK-8294969-

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target b

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target b

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target b

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote: >> javap uses proprietary com.sun.tools.classfile library to parse class files. >> >> This patch converts javap to use Classfile API. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request with a new target b

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v11]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 227

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v10]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 226

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v9]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixed code prin

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v8]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: added DydnamicC

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v7]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: extended ClassR

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v6]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 222

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v5]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 220

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v4]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 218

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v3]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 217

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v2]

> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 215

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API

On Sat, 1 Apr 2023 20:31:05 GMT, Chen Liang wrote: > It's quite complicated to safeguard every potentially erroneous call. I agree, it is complicated, however possible. The question however is whether it is desirable. See for example silently failing `ClhsdbDumpclass` test with many safeguarde

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API

On Tue, 29 Nov 2022 10:26:31 GMT, Adam Sotona wrote: > javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam I took a look at this patch locally; 4 of the javap tests fail. The mai

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API

On Tue, 29 Nov 2022 10:26:31 GMT, Adam Sotona wrote: > javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam failing `hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.java` test is

RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API

javap uses proprietary com.sun.tools.classfile library to parse class files. This patch converts javap to use Classfile API. Please review. Thanks, Adam - Commit messages: - fixed TestClassNameWarning - Merge branch 'master' into JDK-8294969-javap - consolidated safeguarding of