On Wed, 5 Oct 2022 13:46:23 GMT, Raffaello Giulietti
wrote:
>> I am not completely sure all `misleading-indentation` warnings are fixed in
>> Awt2d, this would require some more testing. I'd defer that to #10453.
>
> Awt2dLibraries.gmk in https://github.com/openjdk/jdk/pull/10453 seems more
>
On Wed, 5 Oct 2022 12:07:13 GMT, Aleksey Shipilev wrote:
>> What is the problem with Awt2d? Other conflicts?
>
> I am not completely sure all `misleading-indentation` warnings are fixed in
> Awt2d, this would require some more testing. I'd defer that to #10453.
Awt2dLibraries.gmk in https://git
On Wed, 5 Oct 2022 12:01:00 GMT, Raffaello Giulietti
wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 298:
>>
>>> 296: HEADERS_FROM_SRC := $(LIBLCMS_HEADERS_FROM_SRC), \
>>> 297: DISABLED_WARNINGS_gcc := format-nonliteral type-limits \
>>> 298: undef unused-functi
On Wed, 5 Oct 2022 10:16:10 GMT, Aleksey Shipilev wrote:
>> Raffaello Giulietti has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains two commits:
>>
>> - 8294456: Fix misleading-indentation warnings in JDK
>>
>>Merge branch 'm
On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a
On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti
wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Raffaello Giulietti has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains two commits:
- 829
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.
On Thu, 29 Sep 2022 13:44:40 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/native/libfdlibm/e_asin.c line 102:
>>
>>> 100: } else
>>> 101: t = x*x;
>>> 102: p = t*(pS0+t*(pS1+t*(pS2+t*(pS3+t*(pS4+t*pS5);
>>
>> should we add an opening brace
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
Sure.
-
PR: https://git.openjdk.org/jdk/pull/10487
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
This looks okay, but let's wait for #10426 to integrate first?
-
PR: http
On Thu, 29 Sep 2022 13:40:37 GMT, Daniel Fuchs wrote:
>> This fixes misleading indentations, which allows enabling the (currently
>> disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> src/java.base/share/native/libfdlibm/e_asin.c line 102:
>
>> 100: } else
>> 1
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
src/java.base/share/native/libfdlibm/e_asin.c line 102:
> 100: } else
> 10
This fixes misleading indentations, which allows enabling the (currently
disabled) `misleading-indentation` warning flag on two `.gmk` files.
-
Commit messages:
- 8294456: Fix misleading-indentation warnings in JDK
Changes: https://git.openjdk.org/jdk/pull/10487/files
Webrev: http
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti
wrote:
> This fixes misleading indentations, which allows enabling the (currently
> disabled) `misleading-indentation` warning flag on two `.gmk` files.
The misleading indentation might indicate the original intent of the author,
which mig
17 matches
Mail list logo
