Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v5]

2022-10-04 Thread Brent Christian
On Mon, 3 Oct 2022 21:22:03 GMT, Justin Lu wrote: >> Problem: Unnecessary instances of StringBuffer within java.text (internal >> only) >> >> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method >> names > > Justin Lu has updated the pull request incrementally with one a

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v5]

2022-10-04 Thread Naoto Sato
On Tue, 4 Oct 2022 18:42:52 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/text/DigitList.java line 161: >> >>> 159: public final double getDouble() { >>> 160: if (count == 0) { >>> 161: return 0.0; >> >> The doc for this method is incorrect: >> >> * If (coun

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v5]

2022-10-04 Thread Justin Lu
On Tue, 4 Oct 2022 18:20:26 GMT, Brent Christian wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove temp var >> >> Remove temp variables and replace with method chaining when possible > > src/java.base/share/

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v5]

2022-10-04 Thread Brent Christian
On Mon, 3 Oct 2022 21:22:03 GMT, Justin Lu wrote: >> Problem: Unnecessary instances of StringBuffer within java.text (internal >> only) >> >> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method >> names > > Justin Lu has updated the pull request incrementally with one a

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v5]

2022-10-03 Thread Justin Lu
> Problem: Unnecessary instances of StringBuffer within java.text (internal > only) > > Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method > names Justin Lu has updated the pull request incrementally with one additional commit since the last revision: Remove temp va