Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Alan Bateman
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, I've been testing with this change for some time and it has worked well. - Marked as reviewed by alanb (Reviewer). PR: h

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Aleksey Shipilev
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, Marked as reviewed by shade (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10198

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Aleksey Shipilev
On Mon, 26 Sep 2022 13:29:51 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1842: >> >>> 1840: signalWork(); // propagate at most >>> twice/run >>> 1841: w.topLevelExec(t, q); >>> 1842:

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Doug Lea
On Mon, 26 Sep 2022 13:21:23 GMT, Aleksey Shipilev wrote: >> 8292969: This small change in signal propagation rules improves utilization >> when entry queues are resized, > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1842: > >> 1840: signalW

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Aleksey Shipilev
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1842: > 1840: signalWork();

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Jaikiran Pai
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, Hello Doug, for the bots to trigger the review process, the title of this PR is expected to be `: `, so in this case the title of this

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Martin Buchholz
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, scan's @return needs to be changed to indicate it also now returns a packed int - Changes requested by martin (Reviewer).

Re: RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Doug Lea
On Wed, 7 Sep 2022 12:44:11 GMT, Doug Lea wrote: > 8292969: This small change in signal propagation rules improves utilization > when entry queues are resized, Thanks. replaced with: * @return the next prevSrc value to use, or negative if none found Thanks. I keep forgetting the required

RFR: 8292969: Bad Thread Utilization in ForkJoinPool

2022-09-26 Thread Doug Lea
8292969: This small change in signal propagation rules improves utilization when entry queues are resized, - Commit messages: - Merge remote-tracking branch 'refs/remotes/origin/JDK-8292969' into JDK-8292969 - Merge branch 'openjdk:master' into JDK-8292969 - Update @preturn javad