Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-19 Thread Jaikiran Pai
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. Looks fine to me. - Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk/pull/9816

Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-19 Thread Alex Menkov
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9816

Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-15 Thread Roger Riggs
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. lgtm - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.org/jdk/pull/9816

Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-15 Thread Phil Race
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. Approving (just) the client change - Marked as reviewed by prr (Reviewer). PR: https://git.openjdk.org/jdk/pull/9816

Re: RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-15 Thread ExE Boss
On Wed, 10 Aug 2022 08:01:41 GMT, Andrey Turbanov wrote: > It's a bit shorter and clearer. Also, it avoids unnecessary boxing. - PR: https://git.openjdk.org/jdk/pull/9816

RFR: 8292350: Use static methods for hashCode/toString primitives

2022-08-15 Thread Andrey Turbanov
It's a bit shorter and clearer. - Commit messages: - [PATCH] Use static methods for hashCode/toString primitives Changes: https://git.openjdk.org/jdk/pull/9816/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9816&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292350