On Thu, 13 Oct 2022 19:53:27 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with two additional
On Thu, 13 Oct 2022 19:19:05 GMT, Sean Mullan wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - test update
>> - Merge branch 'master' into secEvent-8292177
>> - Use stringPropertyNames()
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- remove previous edit
-
On Thu, 13 Oct 2022 16:06:13 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request with a new target base due to a
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote:
>> @seanjmullan - I looked at that approach. The
>> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may
>> trigger early initialization of the `java.security.Security` class - I'm not
>> sure if we want that. Protection
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 17 commits:
On Tue, 11 Oct 2022 12:39:14 GMT, Sean Mullan wrote:
>> @seanjmullan - I looked at that approach. The
>> `SharedSecrets.getJavaSecurityAccess().getInitialProperties();` call may
>> trigger early initialization of the `java.security.Security` class - I'm not
>> sure if we want that. Protection
On Tue, 11 Oct 2022 11:28:10 GMT, Sean Coffey wrote:
>> What about creating a new `JavaSecurityPropertiesAccess` class and moving
>> the accessor method there? It seems it would be cleaner to remove the
>> dependency on PD in the long run.
>
> @seanjmullan - I looked at that approach. The
> `
On Mon, 10 Oct 2022 20:54:58 GMT, Sean Mullan wrote:
>> modified code to have Security class hold the initial properties and
>> provided an accessor method
>
> What about creating a new `JavaSecurityPropertiesAccess` class and moving the
> accessor method there? It seems it would be cleaner to
On Mon, 10 Oct 2022 19:23:51 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 10 Oct 2022 19:19:44 GMT, Sean Coffey wrote:
>> Agree, and alternatively, it seems cleaner to add a new SharedSecrets class
>> for `java.security.Security` and remove the dependency on PD.
>
> modified code to have Security class hold the initial properties and provided
> an accessor me
On Mon, 10 Oct 2022 07:19:30 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
> line 29:
>
On Mon, 10 Oct 2022 14:19:18 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/ProtectionDomain.java line 76:
>>
>>> 74: static class JavaSecurityAccessImpl implements JavaSecurityAccess {
>>> 75: /* cache a copy for recording purposes */
>>> 76: static Pro
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Address Oct 10 review com
On Mon, 10 Oct 2022 07:31:29 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/java.base/share/classes/java/security/ProtectionDomain.java line 76:
>
>> 74: s
On Mon, 10 Oct 2022 11:29:52 GMT, Erik Gahlin wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
>> line 33:
>>
>>> 31: @Category({"Java Development Kit", "Security"})
>>> 32: @Label("Initial Security Property")
>>> 33: @Name("jdk.InitialSecurityProperty")
>>
On Mon, 10 Oct 2022 08:04:28 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
> line 33:
>
On Mon, 10 Oct 2022 08:06:45 GMT, Jaikiran Pai wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check for 0 security events
>
> src/jdk.jfr/share/classes/jdk/jfr/events/InitialSecurityPropertyEvent.java
> line 35:
>
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
On Mon, 3 Oct 2022 10:30:54 GMT, Sean Coffey wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> Sean Coffey has updated the pull request incrementally with one additional
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Check for 0 security even
On Fri, 30 Sep 2022 19:32:29 GMT, Sean Mullan wrote:
>> Thanks @egahlin - maybe we can leave it at beginChunk setting then.
>>
>> I've been doing some testing to satisfy myself that the impact of this event
>> on performance is minimal, Running the new `emitInitialSecurityProperties()`
>> is
On Thu, 29 Sep 2022 15:12:06 GMT, Sean Coffey wrote:
>> With event streaming, beginChunk is usually to prefer. Otherwise, a client
>> that monitors the JVM must wait until the first chunk rotation to get the
>> data.
>>
>> That said, we want startup to be quick. There should probably be a comm
On Thu, 29 Sep 2022 11:41:02 GMT, Erik Gahlin wrote:
>> As per yesterday's stack trace, JFR triggers loading of the Security class -
>> so your scenario won't arise with current state. We could include the new
>> Event with period of `endChunk `instead of `beingChunk `setting. That should
>> e
On Thu, 29 Sep 2022 10:02:05 GMT, Sean Coffey wrote:
>> How does it capture the event if JFR was started before the security
>> properties were read? I would think you still need some additional code in
>> Security.java to record the properties if the event is enabled.
>
> As per yesterday's st
On Wed, 28 Sep 2022 16:32:17 GMT, Sean Mullan wrote:
>> Correct - this type of event period (beginChunk) will fire once when the JFR
>> recording is begun. It should capture Security Properties (if
>> java.security.Security is loaded) for any recording, no matter when it might
>> begin or end.
On Wed, 28 Sep 2022 12:52:02 GMT, Sean Coffey wrote:
>> Ok, just so I understand, you want to make sure that if JFR is started after
>> the security properties have already been read, then they are still
>> recorded, right?
>
> Correct - this type of event period (beginChunk) will fire once whe
On Wed, 28 Sep 2022 12:26:49 GMT, Sean Mullan wrote:
>> Yes - the thinking here is that since this is a one time event, we can have
>> it enabled. It's similar to the InitialSystemProperty event.
>>
>> We won't force loading of Security properties/class. We shouldn't at least.
>> If no securi
On Wed, 28 Sep 2022 10:06:54 GMT, Sean Coffey wrote:
>> src/jdk.jfr/share/conf/jfr/default.jfc line 713:
>>
>>> 711:
>>> 712:
>>> 713: true
>>
>> The other security related events are not enabled by default. Is this one
>> enabled because it is only generated once? It seems it may
On Wed, 28 Sep 2022 07:06:30 GMT, Jaikiran Pai wrote:
> Hello Sean,
>
> > Debug output is also now added for these properties via
> > -Djava.security.debug=properties
>
> Looking at the existing code upstream, it appears that the value `properties`
> is already recognized for `java.security.d
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Null check on Properties
On Tue, 27 Sep 2022 20:29:31 GMT, Sean Mullan wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line
On Thu, 22 Sep 2022 15:57:56 GMT, Sean Coffey wrote:
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Hello Sean,
> Debug output is also now added for these properties via
> -Djava.
On Thu, 22 Sep 2022 15:57:56 GMT, Sean Coffey wrote:
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 312:
>
New JFR event to record state of initial security properties.
Debug output is also now added for these properties via
-Djava.security.debug=properties
-
Commit messages:
- merge with master
- Correct test bug ids
- fix up imports
- Add security debug test logic
- Add JFR testc
39 matches
Mail list logo
