On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
If by “surrogates” you mean “substitutes”, then this wording is confusing. At
the time these explicit loops were written they weren’t surrogates for
anything,
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
By "surrogate code" I mean hand-written snippets reading all the bytes from an
InputStream.
> It means the whole content from the input stream is read into a
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
The `X509CertPath.java` change looks fine, but I'm not sure about the other
one. It means the whole content from the input stream is read into a single
array
On Thu, 21 Jul 2022 15:37:40 GMT, Сергей Цыпанов wrote:
> We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
Why do you say “instead of surrogate code”? I don’t see any Unicode surrogate
processing here, but maybe you mean something else. Would “instead of explicit
l
We can use `InputStream.readAllBytes()` in `ModuleHashes` and `X509CertPath`.
-
Commit messages:
- 8290824: Remove unused JavaDoc
- 8290824: Use InputStream.readAllBytes() instead of surrogate code
Changes: https://git.openjdk.org/jdk/pull/9596/files
Webrev: https://webrevs.openjd
