On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Revert erroneous changes
Thanks!
-
PR: https://git.open
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Revert erroneous changes
Anyone to sponsor?
-
PR: https
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Revert erroneous changes
Changes to HttpURLConnection look good to me
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Revert erroneous changes
Marked as reviewed by rriggs (Reviewer).
--
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Revert erroneous changes
Marked as reviewed by naoto (Reviewer).
---
On Mon, 18 Jul 2022 11:31:59 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Remove unused import
Right, my bad. I've confused arguments. The chan
> Simplify code with `String.join()`
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8290300: Revert erroneous changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9513/files
- new: https://git.openjdk.org/jd
On Mon, 18 Jul 2022 11:08:24 GMT, Сергей Цыпанов wrote:
> For `Locale` all the call sites of `formatList()` never pass null, so the
> code in `if` block is never executed. I think we can delete this unused parts
> of the code in `Locale`,
Are you sure about this? `pattern` is derived from
`Lo
> Simplify code with `String.join()`
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8290300: Remove unused import
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9513/files
- new: https://git.openjdk.org/jdk/pu
On Fri, 15 Jul 2022 12:25:07 GMT, Jim Laskey wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8290300: Remove unused piece of code in formatList()
>
> LGTM, however are there tests that ensure the changes are beni
> Simplify code with `String.join()`
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8290300: Remove unused piece of code in formatList()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9513/files
- new: https:/
On Fri, 15 Jul 2022 12:40:50 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8290300: Revert jops
> - 8290300: Revert jops
Changes to `Locale` look good
On Fri, 15 Jul 2022 12:25:07 GMT, Jim Laskey wrote:
>> Сергей Цыпанов has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8290300: Revert jops
>> - 8290300: Revert jops
>
> LGTM, however are there tests that ensure the changes are benign?
On Fri, 15 Jul 2022 12:03:13 GMT, Сергей Цыпанов wrote:
> Simplify code with `String.join()`
Reverted jops
-
PR: https://git.openjdk.org/jdk/pull/9513
> Simplify code with `String.join()`
Сергей Цыпанов has updated the pull request incrementally with two additional
commits since the last revision:
- 8290300: Revert jops
- 8290300: Revert jops
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9513/files
- new: https://git.o
On Fri, 15 Jul 2022 12:03:13 GMT, Сергей Цыпанов wrote:
> Simplify code with `String.join()`
joptsimple is a 3rd party code so we probably don't want to change that.
-
PR: https://git.openjdk.org/jdk/pull/9513
On Fri, 15 Jul 2022 12:03:13 GMT, Сергей Цыпанов wrote:
> Simplify code with `String.join()`
LGTM, however are there tests that ensure the changes are benign?
-
PR: https://git.openjdk.org/jdk/pull/9513
Simplify code with `String.join()`
-
Commit messages:
- 8290300: Fix copy-right year
- 8290300: Use standard String-joining tools where applicable
Changes: https://git.openjdk.org/jdk/pull/9513/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9513&range=00
Issue: https://b
18 matches
Mail list logo
