Re: RFR: 8290036: adjustments to specification of Runtime::addShutdownHook

2022-08-03 Thread Stuart Marks
On Wed, 3 Aug 2022 16:19:42 GMT, Alan Bateman wrote: >> Initial edits to addShutdownHook from Alex. >> >> See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036). > > src/java.base/share/classes/java/lang/Runtime.java line 79: > >> 77: * terminate the JVM via the {@link #halt halt} meth

Re: RFR: 8290036: adjustments to specification of Runtime::addShutdownHook

2022-08-03 Thread Alan Bateman
On Fri, 8 Jul 2022 23:00:15 GMT, Stuart Marks wrote: > Initial edits to addShutdownHook from Alex. > > See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036). src/java.base/share/classes/java/lang/Runtime.java line 69: > 67: * and > 68: * {@link #removeShutdownHook removeShutdownHook

Re: RFR: 8290036: adjustments to specification of Runtime::addShutdownHook

2022-08-02 Thread David Holmes
On Fri, 8 Jul 2022 23:00:15 GMT, Stuart Marks wrote: > Initial edits to addShutdownHook from Alex. > > See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036). Hi Stuart, There's nothing I would consider harmful in these changes, but I also don't see them as necessary. Cheers. src/ja

Re: RFR: 8290036: adjustments to specification of Runtime::addShutdownHook

2022-08-02 Thread Stuart Marks
On Fri, 8 Jul 2022 23:00:15 GMT, Stuart Marks wrote: > Initial edits to addShutdownHook from Alex. > > See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036). Sorry David I should have clarified this a bit. The changes currently in this draft PR are merely what occurred to Alex and me

RFR: 8290036: adjustments to specification of Runtime::addShutdownHook

2022-08-02 Thread Stuart Marks
Initial edits to addShutdownHook from Alex. See [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036). - Commit messages: - Additional wording changes to Runtime specs. - HTML fixups; updates in response to review comments. - Updates to Runtime class spec, exit, halt, and Sys