Re: RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows [v3]

2024-11-19 Thread Alexander Matveev
On Tue, 19 Nov 2024 22:07:10 GMT, Alexey Semenyuk wrote: >> Fix `ResourceEditor` class to handle long paths. >> >> Based on https://github.com/openjdk/jdk/pull/9384 PR. >> >> This repairs app image building on Windows if the path to jpackage temp >> directory exceeds 260 (`MAX_PATH`) character

Re: RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows [v3]

2024-11-19 Thread Alexey Semenyuk
On Tue, 19 Nov 2024 23:55:33 GMT, Alexander Matveev wrote: >> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make path guaranteed to be long enough > > test/jdk/tools/jpackage/windows/WinLongPathTest.java line 38: > >>

Re: RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows [v3]

2024-11-19 Thread Alexander Matveev
On Tue, 19 Nov 2024 22:07:10 GMT, Alexey Semenyuk wrote: >> Fix `ResourceEditor` class to handle long paths. >> >> Based on https://github.com/openjdk/jdk/pull/9384 PR. >> >> This repairs app image building on Windows if the path to jpackage temp >> directory exceeds 260 (`MAX_PATH`) character

Re: RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows [v3]

2024-11-19 Thread Alexey Semenyuk
> Fix `ResourceEditor` class to handle long paths. > > Based on https://github.com/openjdk/jdk/pull/9384 PR. > > This repairs app image building on Windows if the path to jpackage temp > directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken > and can NOT be repaired due to

Re: RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows [v2]

2024-11-19 Thread Alexey Semenyuk
> Fix `ResourceEditor` class to handle long paths. > > Based on https://github.com/openjdk/jdk/pull/9384 PR. > > This repairs app image building on Windows if the path to jpackage temp > directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken > and can NOT be repaired due to

RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows

2024-11-19 Thread Alexey Semenyuk
Fix `ResourceEditor` class to handle long paths. Based on https://github.com/openjdk/jdk/pull/9384 PR. This repairs app image building on Windows if the path to jpackage temp directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken and can NOT be repaired due to WiX's limitat

Re: RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows

2024-11-19 Thread Alexey Semenyuk
On Thu, 14 Nov 2024 04:40:37 GMT, Alexey Semenyuk wrote: > Fix `ResourceEditor` class to handle long paths. > > Based on https://github.com/openjdk/jdk/pull/9384 PR. > > This repairs app image building on Windows if the path to jpackage temp > directory exceeds 260 (`MAX_PATH`) characters. MSI