> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
On Fri, 7 Jul 2023 19:42:18 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Harde
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Harden code to report lack of SSL support
- Testcase correction
On Fri, 7 Jul 2023 13:40:53 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 123:
>>
>>> 121: }
>>> 122:
>>> 123: ostream.println(INDENT + "Security TLS configuration:");
>>
>> What about also noting the name of the TLS/JSSE provide
On Thu, 6 Jul 2023 14:03:12 GMT, Sean Mullan wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits sinc
On Thu, 6 Jul 2023 18:43:41 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits sinc
On Thu, 6 Jul 2023 17:15:20 GMT, Mandy Chung wrote:
> > The changes make me wonder if `-XshowSetting:aardvark` should be an error
> > rather than default to print all settings. Something we should look at
> > again. Same thing for `-XshowSettings:system` on non-Linux, probably should
> > have
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
On Thu, 29 Jun 2023 08:27:43 GMT, Alan Bateman wrote:
> The changes make me wonder if `-XshowSetting:aardvark` should be an error
> rather than default to print all settings. Something we should look at again.
> Same thing for `-XshowSettings:system` on non-Linux, probably should have
> been a
On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
On Tue, 27 Jun 2023 15:06:45 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
On Mon, 19 Jun 2023 18:21:49 GMT, Roger Riggs wrote:
>> @RogerRiggs - do you mean to print nothing in the "bad command input"
>> scenario ? The current -XshowSettings launch behaviour prints all data if a
>> bad value is passed to it. I was mimicking this for security subcommands.
>>
>> Are
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Don't allow bad subcommand values for security component
-
On Mon, 19 Jun 2023 16:11:12 GMT, Sean Coffey wrote:
>> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 66:
>>
>>> 64: ostream.println("Unrecognized security subcommand. See
>>> \"java -X\" for help");
>>> 65: ostream.println("Printing all sec
On Fri, 16 Jun 2023 11:23:48 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor out security code to helper class
>> - Print aliases. Order Provider type/service output.
>
> src/java.base/
On Sat, 17 Jun 2023 01:51:36 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass PrintStream to security helper
>
> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 93:
>
>> 91:
On Fri, 16 Jun 2023 11:23:48 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor out security code to helper class
>> - Print aliases. Order Provider type/service output.
>
> src/java.base/
On Fri, 16 Jun 2023 15:15:59 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Pass PrintStream to security helper
>
> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 66:
>
>> 64:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- restore more informative help message
- Split long properties for ; a
On Fri, 16 Jun 2023 12:14:49 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Pass P
On Fri, 16 Jun 2023 12:14:49 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Pass P
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Pass PrintStream to security helper
-
Changes:
- all: ht
On Fri, 16 Jun 2023 11:09:23 GMT, Sean Coffey wrote:
> Logged https://bugs.openjdk.org/browse/JDK-8310201 to track the Locale
> changes Alan.
Thanks, probably should treat this as a bug for JDK 21 so that a new addition
doesn't change behavior between 21 and 22.
-
PR Review Comme
On Fri, 16 Jun 2023 11:14:38 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Refa
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Wed, 14 Jun 2023 14:06:33 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 424:
>>
>>> 422:if (!services.isEmpty()) {
>>> 423:services.stream()
>>> 424:
>>> .sorted(Comparator.comparing
On Thu, 15 Jun 2023 06:32:06 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 183:
>>
>>> 181: case "locale":
>>> 182: printLocale();
>>> 183: break;
>>
>> printLocale might need the same treatment to avoid
On Wed, 14 Jun 2023 12:46:36 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.ja
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with two additional
commits since the last revision:
- Refactor out security code to helper class
- Print aliases. Order Pro
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Thu, 15 Jun 2023 06:29:09 GMT, Alan Bateman wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.j
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Wed, 14 Jun 2023 11:52:35 GMT, Weijun Wang wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporate review comments from Roger and tweak some code
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.ja
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
On Wed, 14 Jun 2023 11:39:14 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Incorp
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Incorporate review comments from Roger and tweak some code
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
On Tue, 13 Jun 2023 14:30:57 GMT, Roger Riggs wrote:
>> Sean Coffey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits si
On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey wrote:
>> New functionality in the -XshowSettings menu to display relevant information
>> about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev exclu
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Sean Coffey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Thanks for the feedback to date. I've pushed new changes to reflect requested
changes. I've changed the default` -XshowSettings
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 330:
> 328: if (arg.toLowerCase(Locale.ROOT).equals("p
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Another possibility is to put this under a new option, ex
`-XshowSecuritySettings`.
-
PR Comment: https://git.open
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Thanks for the reviews to date. All good comments, I'll implement.
Yes, the output of `-XShowSettings` is more verbose. Let me t
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 349:
> 347: // split lines longer than 60 char
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
There is a lot of output and does seem to overwhelm the java -XshowSettings
output with detail that I wouldn't expect by default
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
Did you consider only showing the security settings if the "security" option is
specified? Seems like a lot of data to show in t
On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey wrote:
> New functionality in the -XshowSettings menu to display relevant information
> about JDK security configuration
src/java.base/share/classes/sun/launcher/LauncherHelper.java line 65:
> 63: import java.text.MessageFormat;
> 64: import java.te
New functionality in the -XshowSettings menu to display relevant information
about JDK security configuration
-
Commit messages:
- minor edits, copyright, descriptions etc
- Merge branch 'master' into 8281658-showsettings-security
- Merge branch 'master' into 8281658-showsettings-
53 matches
Mail list logo
