Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-10-01 Thread Markus KARG
On Sun, 11 Sep 2022 08:04:36 GMT, Markus KARG wrote: > I think you are asking if is safe to leak a reference to the internal buffer. > If there is no mark then it might be okay because there is no replay for an > evil output stream to attack. However, I think it would require wider review > to

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-28 Thread Brian Burkhalter
On Mon, 26 Sep 2022 21:35:26 GMT, Brian Burkhalter wrote: >> @bplb Fixed the issues you pointed out. Kindly requesting approval. :-) > >> @bplb Fixed the issues you pointed out. > > @mkarg You are welcome. > @bplb I would be very glad if you would `/sponsor` my PR. :-) Done. - PR

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-27 Thread Markus KARG
On Mon, 26 Sep 2022 21:35:26 GMT, Brian Burkhalter wrote: >> @bplb Fixed the issues you pointed out. Kindly requesting approval. :-) > >> @bplb Fixed the issues you pointed out. > > @mkarg You are welcome. @bplb I would be very glad if you would `/sponsor` my PR. :-) - PR: https:/

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-26 Thread Brian Burkhalter
On Sat, 24 Sep 2022 12:14:49 GMT, Markus KARG wrote: > @bplb Fixed the issues you pointed out. @mkarg You are welcome. - PR: https://git.openjdk.org/jdk/pull/6935

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-25 Thread Markus KARG
On Sun, 25 Sep 2022 07:28:56 GMT, Alan Bateman wrote: >>> I do not quite understand what would be wrong with the code below instead >>> of falling back to the super implementation _in case of non-empty buffer_? >> >> I think you are asking if is safe to leak a reference to the internal >> buff

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-25 Thread Markus KARG
On Sun, 25 Sep 2022 07:28:56 GMT, Alan Bateman wrote: > > @AlanBateman Kindly requesting approval. :-) > > I don't have any more comments, the recent test cleanups are good. I assume > @bplb will sponsor. Thanks a lot for all your kind help with this PR! :-) - PR: https://git.ope

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-25 Thread Alan Bateman
On Sun, 11 Sep 2022 07:44:44 GMT, Alan Bateman wrote: >> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - corrected copyright >> - testing transferTo() after reset() > >> I do not quite understand what would be wrong with t

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-24 Thread Markus KARG
On Thu, 22 Sep 2022 22:14:02 GMT, Brian Burkhalter wrote: >> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - corrected copyright >> - testing transferTo() after reset() > > test/jdk/java/io/BufferedInputStream/TransferTo.j

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-24 Thread Markus KARG
On Fri, 9 Sep 2022 12:19:54 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with two additional > commits since the last revision: > > - corrected copyright > - testing transferTo() after reset() @bplb Fixed the issues you p

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-22 Thread Brian Burkhalter
On Fri, 9 Sep 2022 12:19:54 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with two additional > commits since the last revision: > > - corrected copyright > - testing transferTo() after reset() test/jdk/java/io/BufferedInp

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-17 Thread Markus KARG
On Sun, 11 Sep 2022 07:44:44 GMT, Alan Bateman wrote: >> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - corrected copyright >> - testing transferTo() after reset() > >> I do not quite understand what would be wrong with t

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-11 Thread Markus KARG
On Sun, 11 Sep 2022 07:44:44 GMT, Alan Bateman wrote: > > I do not quite understand what would be wrong with the code below instead > > of falling back to the super implementation _in case of non-empty buffer_? > > I think you are asking if is safe to leak a reference to the internal buffer. >

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-11 Thread Alan Bateman
On Fri, 9 Sep 2022 12:19:54 GMT, Markus KARG wrote: >> Implementation of JDK-8279283 > > Markus KARG has updated the pull request incrementally with two additional > commits since the last revision: > > - corrected copyright > - testing transferTo() after reset() > I do not quite understand

Re: RFR: 8279283 - BufferedInputStream should override transferTo [v11]

2022-09-09 Thread Markus KARG
> Implementation of JDK-8279283 Markus KARG has updated the pull request incrementally with two additional commits since the last revision: - corrected copyright - testing transferTo() after reset() - Changes: - all: https://git.openjdk.org/jdk/pull/6935/files - new: https://