On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/ut
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/ut
On Wed, 1 May 2024 10:03:25 GMT, Pavel Rappo wrote:
>> The grammar rules prefer "that" because it is a restrictive clause, even
>> though "which" might sound better. See for example:
>> https://owl.purdue.edu/owl/general_writing/grammar/that_vs_which.html
>
>> The grammar rules prefer "that" b
On Wed, 1 May 2024 10:03:25 GMT, Pavel Rappo wrote:
>> The grammar rules prefer "that" because it is a restrictive clause, even
>> though "which" might sound better. See for example:
>> https://owl.purdue.edu/owl/general_writing/grammar/that_vs_which.html
>
>> The grammar rules prefer "that" b
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/ut
On Tue, 30 Apr 2024 19:41:54 GMT, Doug Lea wrote:
> The grammar rules prefer "that" because it is a restrictive clause, even
> though "which" might sound better. See for example:
> https://owl.purdue.edu/owl/general_writing/grammar/that_vs_which.html
Thanks for that link, Doug.
I understand t
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/ut
On Tue, 30 Apr 2024 12:38:02 GMT, Viktor Klang wrote:
> @pavelrappo Wdyt?
I like it, but maybe native speakers who also write clearly could double check
that change from _which_ to _that_? In no particular order: @DougLea,
@AlanBateman, @stuart-marks.
-
PR Comment: https://git.op
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/ut
> This is an attempt to be more clear about recommendations on Lock usage.
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java
Co-authored-by:
On Fri, 26 Apr 2024 11:43:06 GMT, Viktor Klang wrote:
> This is an attempt to be more clear about recommendations on Lock usage.
src/java.base/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java
line 162:
> 160: * }
> 161: * }
> 162: * // Make sure that code w
On Fri, 26 Apr 2024 11:43:06 GMT, Viktor Klang wrote:
> This is an attempt to be more clear about recommendations on Lock usage.
Thanks for finally processing this after we let this good suggestion sit for
too long!
-
PR Comment: https://git.openjdk.org/jdk/pull/18974#issuecomment
On Fri, 26 Apr 2024 11:43:06 GMT, Viktor Klang wrote:
> This is an attempt to be more clear about recommendations on Lock usage.
@stuart-marks Would this be better? 🤔
-
PR Comment: https://git.openjdk.org/jdk/pull/18974#issuecomment-2079225009
This is an attempt to be more clear about recommendations on Lock usage.
-
Commit messages:
- Adding more clarification to proper usage of locks
Changes: https://git.openjdk.org/jdk/pull/18974/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18974&range=00
Issue: https://b
14 matches
Mail list logo
