Re: RFR: 8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator

2022-09-26 Thread Brian Burkhalter
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote: > Problem: Unnecessary instances of StringBuffer + .toString() > > Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when > possible > > Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion, > but

RFR: 8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator

2022-09-26 Thread Justin Lu
Problem: Unnecessary instances of StringBuffer + .toString() Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when possible Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion, but removing that instance requires changing the RuleBasedCollationKey

Re: RFR: 8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator

2022-09-26 Thread Lance Andersen
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote: > Problem: Unnecessary instances of StringBuffer + .toString() > > Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when > possible > > Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion, > but

Re: RFR: 8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator

2022-09-26 Thread Brent Christian
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote: > Problem: Unnecessary instances of StringBuffer + .toString() > > Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when > possible > > Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion, > but

Re: RFR: 8272687: Replace StringBuffer with StringBuilder in RuleBasedCollator

2022-09-26 Thread Naoto Sato
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote: > Problem: Unnecessary instances of StringBuffer + .toString() > > Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when > possible > > Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion, > but